changeset 12420:b7d77321b685

[gaim-migrate @ 14727] gaim_accounts_reorder() should not be using size_t for new_index. I fixed it to use gint, the type of all the g_list functions involved. committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Thu, 08 Dec 2005 21:50:49 +0000
parents 455610a80747
children f71d6b79ec81
files plugins/ChangeLog.API src/account.c src/account.h src/gtkaccount.c
diffstat 4 files changed, 6 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/plugins/ChangeLog.API	Thu Dec 08 21:08:15 2005 +0000
+++ b/plugins/ChangeLog.API	Thu Dec 08 21:50:49 2005 +0000
@@ -68,6 +68,7 @@
 	                             the added user, that's left up to the prpls.
 	                             See the documentation for this function and
 	                             gaim_account_request_add.
+	* gaim_accounts_reorder: new_index is now a gint instead of a size_t
 
 	Removed:
 	* gaim_gtk_sound_{get,set}_mute() (replaced by the /gaim/gtk/sound/mute
--- a/src/account.c	Thu Dec 08 21:08:15 2005 +0000
+++ b/src/account.c	Thu Dec 08 21:50:49 2005 +0000
@@ -2146,13 +2146,13 @@
 }
 
 void
-gaim_accounts_reorder(GaimAccount *account, size_t new_index)
+gaim_accounts_reorder(GaimAccount *account, gint new_index)
 {
-	size_t index;
+	gint index;
 	GList *l;
 
 	g_return_if_fail(account != NULL);
-	g_return_if_fail(new_index >= 0 && new_index <= g_list_length(accounts));
+	g_return_if_fail(new_index <= g_list_length(accounts));
 
 	index = g_list_index(accounts, account);
 
--- a/src/account.h	Thu Dec 08 21:08:15 2005 +0000
+++ b/src/account.h	Thu Dec 08 21:50:49 2005 +0000
@@ -815,7 +815,7 @@
  * @param account   The account to reorder.
  * @param new_index The new index for the account.
  */
-void gaim_accounts_reorder(GaimAccount *account, size_t new_index);
+void gaim_accounts_reorder(GaimAccount *account, gint new_index);
 
 /**
  * Returns a list of all accounts.
--- a/src/gtkaccount.c	Thu Dec 08 21:08:15 2005 +0000
+++ b/src/gtkaccount.c	Thu Dec 08 21:50:49 2005 +0000
@@ -1987,7 +1987,7 @@
 					  guint info, guint t, AccountsWindow *dialog)
 {
 	if (sd->target == gdk_atom_intern("GAIM_ACCOUNT", FALSE) && sd->data) {
-		size_t dest_index;
+		gint dest_index;
 		GaimAccount *a = NULL;
 		GtkTreePath *path = NULL;
 		GtkTreeViewDropPosition position;