changeset 25117:c1f85543556d

merge of 'afc2bc7354c9b7ddb6cb80de073d5ae620fe94a5' and 'b79100551ea19cf35ee8952a34a44b97204e75f3'
author Etan Reisner <pidgin@unreliablesource.net>
date Thu, 12 Feb 2009 06:06:40 +0000
parents eece2d17ab65 (current diff) fa5987472e00 (diff)
children 463d8501e4e0
files
diffstat 1 files changed, 8 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/account.h	Thu Feb 12 06:02:20 2009 +0000
+++ b/libpurple/account.h	Thu Feb 12 06:06:40 2009 +0000
@@ -132,6 +132,14 @@
 								/*   to NULL when the account inherits      */
 								/*   proxy settings from global prefs.      */
 
+	/*
+	 * TODO: Supplementing the next two linked lists with hash tables
+	 * should help performance a lot when these lists are long.  This
+	 * matters quite a bit for protocols like MSN, where all your
+	 * buddies are added to your permit list.  Currently we have to
+	 * iterate through the entire list if we want to check if someone
+	 * is permitted or denied.  We should do this for 3.0.0.
+	 */
 	GSList *permit;             /**< Permit list.                           */
 	GSList *deny;               /**< Deny list.                             */
 	int perm_deny;              /**< The permit/deny setting.               */