Mercurial > pidgin.yaz
changeset 12174:c7652a910308
[gaim-migrate @ 14476]
KingAnt said:
"And if double-clicking loads a plugin, then double-clicking
again must unload the plugin. However, I think it's better
if double-clicking either opens the preferences or does nothing."
I disagree that double-clicking again must undo what happened from the first time, and in this case, that would totally defeat the goal. Given that this is possibly confusing no matter how we do it, let's take the safest route and not enable the plugin if it's not already. This still accomplishes my main goal of being able to double-click on a plugin I'm using to see its prefs.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Sun, 20 Nov 2005 22:09:24 +0000 |
| parents | 81c63578aa39 |
| children | a655bdeb561d |
| files | src/gtkplugin.c |
| diffstat | 1 files changed, 2 insertions(+), 8 deletions(-) [+] |
line wrap: on
line diff
--- a/src/gtkplugin.c Sun Nov 20 21:22:39 2005 +0000 +++ b/src/gtkplugin.c Sun Nov 20 22:09:24 2005 +0000 @@ -349,15 +349,9 @@ gtk_tree_model_get(model, &iter, 2, &plugin, -1); - /* If the plugin is not loaded, then load it first. */ if (!gaim_plugin_is_loaded(plugin)) - { - GtkTreePath *path = gtk_tree_model_get_path(model, &iter); - gchar *pth = gtk_tree_path_to_string(path); - gtk_tree_path_free(path); - plugin_load(NULL, pth, model); - g_free(pth); - } + return; + /* Now show the pref-dialog for the plugin */ plugin_dialog_response_cb(NULL, 98121, sel); }