changeset 21724:d69d729ba19c

The current oscar max message size appears to be 2544. I don't know of a way to get this value from the server, but it seems likely that they probably send it to us somewhere. Anyhoo, this makes our error handling a little nicer when trying to send a message that's too large
author Mark Doliner <mark@kingant.net>
date Sun, 02 Dec 2007 09:25:29 +0000
parents b3e4b81456b0
children 960c07f6f052
files libpurple/protocols/oscar/family_icbm.c libpurple/protocols/oscar/oscar.h
diffstat 2 files changed, 2 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/oscar/family_icbm.c	Sun Dec 02 08:39:31 2007 +0000
+++ b/libpurple/protocols/oscar/family_icbm.c	Sun Dec 02 09:25:29 2007 +0000
@@ -290,7 +290,7 @@
 		if (!args->msg || (args->msglen <= 0))
 			return -EINVAL;
 
-		if (args->msglen >= MAXMSGLEN)
+		if (args->msglen > MAXMSGLEN)
 			return -E2BIG;
 	}
 
--- a/libpurple/protocols/oscar/oscar.h	Sun Dec 02 08:39:31 2007 +0000
+++ b/libpurple/protocols/oscar/oscar.h	Sun Dec 02 09:25:29 2007 +0000
@@ -94,11 +94,8 @@
  * for WinAIM clients (up through the latest (4.0.1957)) to
  * send any more than 1kb.  Amaze all your windows friends
  * with utterly oversized instant messages!
- *
- * TODO: the real limit is the total SNAC size at 8192. Fix this.
- *
  */
-#define MAXMSGLEN 7987
+#define MAXMSGLEN 2544
 
 /*
  * Maximum size of a Buddy Icon.