changeset 9327:ef8e4740254d

[gaim-migrate @ 10135] I think this is better. So updating the same GaimBuddyIcon doesn't accidently destroy it. committer: Tailor Script <tailor@pidgin.im>
author Tim Ringenbach <marv@pidgin.im>
date Sun, 20 Jun 2004 08:02:39 +0000
parents 5ca18080b6bd
children 33e6b2b92cfe
files src/buddyicon.c
diffstat 1 files changed, 4 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/src/buddyicon.c	Sun Jun 20 07:47:20 2004 +0000
+++ b/src/buddyicon.c	Sun Jun 20 08:02:39 2004 +0000
@@ -67,11 +67,12 @@
 							(char *)gaim_buddy_icon_get_username(icon), icon);
 	}
 
+	gaim_buddy_icon_ref(icon);
 	gaim_buddy_icon_set_data(icon, icon_data, icon_len);
+	gaim_buddy_icon_unref(icon);
 
-	/* We don't take a reference here. In fact we may want to check if we have
-	 * a reference (gaim_buddy_icon_set_data should have added one or more)
-	 * and destroy ourselves if we don't.
+	/* We don't take a reference here. gaim_buddy_icon_set_data() makes blist.c or
+	   conversation.c, or both, do that for us.
 	 */
 	return icon;
 }