Mercurial > pidgin.yaz

changeset 22460:f693749f82d2

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Leak fix from SF bug #1407047 which actually had a patch attached (on 2006-01-17 !)
author Stu Tomlinson <stu@nosnilmot.com>
date Thu, 13 Mar 2008 01:34:09 +0000
parents 0daeabc1a185
children 723c7f610d2d
files pidgin/gtkplugin.c
diffstat 1 files changed, 7 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/pidgin/gtkplugin.c	Thu Mar 13 01:24:51 2008 +0000
+++ b/pidgin/gtkplugin.c	Thu Mar 13 01:34:09 2008 +0000
@@ -81,9 +81,7 @@
 
 		config = pidgin_plugin_pref_create_frame(frame);
 
-		/* XXX According to bug #1407047 this broke saving pluging preferences, I'll look at fixing it correctly later.
-		purple_plugin_pref_frame_destroy(frame);
-		*/
+		plugin->info->prefs_info->frame = frame;
 	}
 
 	return config;
@@ -212,6 +210,12 @@
 			plugin_pref_dialogs = NULL;
 		}
 		gtk_widget_destroy(d);
+
+		if (plug->info->prefs_info && plug->info->prefs_info->frame) {
+			purple_plugin_pref_frame_destroy(plug->info->prefs_info->frame);
+			plug->info->prefs_info->frame = NULL;
+		}
+
 		break;
 	}
 }