annotate AUTHORS @ 11719:109ee3bfeac5

[gaim-migrate @ 14010] SF Patch #1333770 from corfe83 "Many times in gaim we use the function g_slist_remove(list,node->data) to remove an element from a GSList. If we already have the pointer to the node we want to delete, it is faster to send it the pointer to the node to delete rather than the data of the node (we can do this by calling g_slist_delete_link(list,node)). This change was made while looking at glib's documentation and the code in glib's gslist.c. This is because as the remove/delete function traverses each node in the list, it doesn't need to spend an extra memory access to retrieve the data for each element in the node it is traversing and then compare, it can simply compare the pointer. In my tests outside of gaim, this makes a big difference if the node you are deleting is at a high index in the list. However, even if you're deleting the first node, it about breaks even. So, I've found each case in gaim where we are calling g_slist_remove, and we already have the pointer to the appropriate node to delete (this is often the case when we're doing a for or while loop on a GSList). I've then replaced it with the appropriate call to g_slist_delete_link. I, however, didn't do this in situations where we are explicitly removing the first element in the list, because in those situations it is an unnecessary change. There should be no difference in behavior, but just in case I've tried running it with valgrind, which reports the same number of memory leaks after my patch as before my patch. Of course, I can't guarantee that my normal behavior on gaim is hitting all the functions I've changed, but in general testing it Works For Me (tm)." As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying. committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Sat, 22 Oct 2005 20:48:18 +0000
parents 03ee9d7360a3
children 1c8ea8f3b84e
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
a5ace2e037bc Tailorization
Tailor Script <tailor@pidgin.im>
parents:
diff changeset
1 gaim - the Pimpin' Penguin IM Clone that's Good for the Soul
1606
bb2b3c18b13d [gaim-migrate @ 1616]
Rob Flynn <gaim@robflynn.com>
parents: 1044
diff changeset
2 ============================================================
0
a5ace2e037bc Tailorization
Tailor Script <tailor@pidgin.im>
parents:
diff changeset
3
4990
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
4 We've got an IRC room now too, #gaim on irc.freenode.net. Come check us out.
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
5
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
6 Active Developers:
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
7 ------------------
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
8
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
9 Sean Egan <bj91704@binghamton.edu> - Lead Developer
2966
1989e781909c [gaim-migrate @ 2979]
Rob Flynn <gaim@robflynn.com>
parents: 2939
diff changeset
10 AIM: SeanEgn
2993
7239a392486c [gaim-migrate @ 3006]
Rob Flynn <gaim@robflynn.com>
parents: 2966
diff changeset
11 ICQ: 96642211
7239a392486c [gaim-migrate @ 3006]
Rob Flynn <gaim@robflynn.com>
parents: 2966
diff changeset
12 MSN: SeanEgn@hotmail.com
7239a392486c [gaim-migrate @ 3006]
Rob Flynn <gaim@robflynn.com>
parents: 2966
diff changeset
13 Yahoo: SeanEgn
7239a392486c [gaim-migrate @ 3006]
Rob Flynn <gaim@robflynn.com>
parents: 2966
diff changeset
14 Jabber: SeanEgn@jabber.org
2966
1989e781909c [gaim-migrate @ 2979]
Rob Flynn <gaim@robflynn.com>
parents: 2939
diff changeset
15
10508
4cc999cc6718 [gaim-migrate @ 11802]
Luke Schierer <lschiere@pidgin.im>
parents: 10369
diff changeset
16 Daniel 'datallah' Atallah
4990
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
17 Christian 'ChipX86' Hammond - Developer & Webmaster
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
18 Herman 'Hermanator' Bloggs - Win32 Port
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
19 Nathan 'faceprint' Walp - Developer
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
20 Mark 'KingAnt' Doliner - Developer
9623
a6351c2b1150 [gaim-migrate @ 10467]
Luke Schierer <lschiere@pidgin.im>
parents: 8195
diff changeset
21 Ethan 'Paco-Paco' Blanton - Developer
a6351c2b1150 [gaim-migrate @ 10467]
Luke Schierer <lschiere@pidgin.im>
parents: 8195
diff changeset
22 Tim 'marv' Ringenbach - Developer
4990
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
23 Luke 'LSchiere' Schierer - Support
10369
584c792dd15c [gaim-migrate @ 11588]
Luke Schierer <lschiere@pidgin.im>
parents: 9906
diff changeset
24 Etan 'deryni' Reisner - Developer
10880
792eb4a1ed82 [gaim-migrate @ 12575]
Gary Kramlich <grim@reaperworld.com>
parents: 10677
diff changeset
25 Stu 'nosnilmot' Tomlinson - Developer
792eb4a1ed82 [gaim-migrate @ 12575]
Gary Kramlich <grim@reaperworld.com>
parents: 10677
diff changeset
26 Gary 'grim' Kramlich - Developer
11342
03ee9d7360a3 [gaim-migrate @ 13556]
Richard Laager <rlaager@wiktel.com>
parents: 10880
diff changeset
27 Richard 'rlaager' Laager
1044
77b6bc7288d3 [gaim-migrate @ 1054]
Rob Flynn <gaim@robflynn.com>
parents: 877
diff changeset
28
4990
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
29 Crazy Patch Writers:
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
30 --------------------
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
31
9623
a6351c2b1150 [gaim-migrate @ 10467]
Luke Schierer <lschiere@pidgin.im>
parents: 8195
diff changeset
32 Ka-Hing 'javabsp' Cheung
9906
e98e97f99df3 [gaim-migrate @ 10798]
Luke Schierer <lschiere@pidgin.im>
parents: 9623
diff changeset
33 Felipe 'shx' Contreras
4990
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
34 Decklin Foster
11342
03ee9d7360a3 [gaim-migrate @ 13556]
Richard Laager <rlaager@wiktel.com>
parents: 10880
diff changeset
35 Peter 'Bleeter' Lawler
9623
a6351c2b1150 [gaim-migrate @ 10467]
Luke Schierer <lschiere@pidgin.im>
parents: 8195
diff changeset
36 Robert 'Robot101' McQueen
a6351c2b1150 [gaim-migrate @ 10467]
Luke Schierer <lschiere@pidgin.im>
parents: 8195
diff changeset
37 Benjamin Miller
a6351c2b1150 [gaim-migrate @ 10467]
Luke Schierer <lschiere@pidgin.im>
parents: 8195
diff changeset
38 Kevin 'SimGuy' Stange
1044
77b6bc7288d3 [gaim-migrate @ 1054]
Rob Flynn <gaim@robflynn.com>
parents: 877
diff changeset
39
1606
bb2b3c18b13d [gaim-migrate @ 1616]
Rob Flynn <gaim@robflynn.com>
parents: 1044
diff changeset
40 Retired:
bb2b3c18b13d [gaim-migrate @ 1616]
Rob Flynn <gaim@robflynn.com>
parents: 1044
diff changeset
41 --------
11342
03ee9d7360a3 [gaim-migrate @ 13556]
Richard Laager <rlaager@wiktel.com>
parents: 10880
diff changeset
42 Rob Flynn <gaim@robflynn.com> - Former Maintainer
4990
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
43 Adam Fritzler - Former libfaim Maintainer
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
44 Eric Warmenhoven <eric@warmenhoven.org> - Former Lead Developer
9623
a6351c2b1150 [gaim-migrate @ 10467]
Luke Schierer <lschiere@pidgin.im>
parents: 8195
diff changeset
45 Jim Duchek <jimduchek@ou.edu> - Former Maintainer
4990
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
46 Jim Seymour - Former Jabber Developer
1044
77b6bc7288d3 [gaim-migrate @ 1054]
Rob Flynn <gaim@robflynn.com>
parents: 877
diff changeset
47 Mark Spencer <markster@marko.net> - Original Author
4990
f514aa3c01db [gaim-migrate @ 5325]
Rob Flynn <gaim@robflynn.com>
parents: 4404
diff changeset
48 Syd Logan - Hacker and Designated Driver (lazy bum)