annotate gaim.desktop @ 8672:142108e89399

[gaim-migrate @ 9424] "This patch contains two fixes. The first is rather trivial, just removes the declaration of extra pointer used for deleting a message and deletes the message directly. The second is the real bug that needed fixing. Short Explanation: The old code only fixed the message that was being displayed, and still sent the original unchecked message to the receiving party. All I did was add a handler to the load_plugin function to make it fix the message being sent as well. Longer Explanation: In my cursory look through the gaim code (warning, <15 minutes) it appears the message pointer send to all the various *-im-msg and *-chat-msg handlers is a copy of the original string each time. This means if you fix the string at one stage (displaying), you have to fix it again at the next (sending). This seems rather inefficient, but hey, it's your client, maybe it was a design feature. Anyway, the spellchk plugin was only fixing the displayed message, and not the message being sent. So I thought my messages were being fixed while those receiving them new I was screwing up. I added substitute_somethingorother handler for the sending-im-msg callback in the load_plugin function. Other comments: I didn't look to deeply into it since it's so late, but the "displaying-chat-msg" and "sending-chat-msg" callbacks appear to be broken. The spellchk.c currently has a handler registered for the first callback, but the message displayed on my screen still contains the original typos. If I try to register a handler for the second callback listed, Gaim crashes when sending the message to a chat window. As I said, I didn't look into why it was crashing, I just removed my attempt to handle it and built this patch." --Matt Brenneke committer: Tailor Script <tailor@pidgin.im>
author Luke Schierer <lschiere@pidgin.im>
date Fri, 16 Apr 2004 14:39:34 +0000
parents 86be4a8dc0a5
children f7ee50e4d534
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
325
9e7d74bc5474 [gaim-migrate @ 335]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
1 [Desktop Entry]
3726
d85208a99af2 [gaim-migrate @ 3862]
Luke Schierer <lschiere@pidgin.im>
parents: 3364
diff changeset
2 Encoding=UTF-8
325
9e7d74bc5474 [gaim-migrate @ 335]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
3 Name=Gaim
3726
d85208a99af2 [gaim-migrate @ 3862]
Luke Schierer <lschiere@pidgin.im>
parents: 3364
diff changeset
4 Comment=Multi-protocol Instant Messaging Client
7307
e11fa8e10a2e [gaim-migrate @ 7891]
Luke Schierer <lschiere@pidgin.im>
parents: 7168
diff changeset
5 Comment[it]=Client Multi-Protocollo per Messaggi Immediati
4305
d567b52d5ed2 [gaim-migrate @ 4559]
Luke Schierer <lschiere@pidgin.im>
parents: 3726
diff changeset
6 Comment[es]=Cliente de mensajería instantánea multiprotocolo
4472
e73c4e8e2d03 [gaim-migrate @ 4747]
Luke Schierer <lschiere@pidgin.im>
parents: 4305
diff changeset
7 Comment[fr]=Client de messagerie instantanée multiprotocole
4589
eddb870a3c4d [gaim-migrate @ 4873]
Luke Schierer <lschiere@pidgin.im>
parents: 4472
diff changeset
8 Comment[de]=Multi-Protokoll Instant Messenger Client
7360
db2c51ef0c54 [gaim-migrate @ 7953]
Luke Schierer <lschiere@pidgin.im>
parents: 7307
diff changeset
9 Comment[ko]=다중 프로토콜 메신저
7663
86be4a8dc0a5 [gaim-migrate @ 8307]
Luke Schierer <lschiere@pidgin.im>
parents: 7360
diff changeset
10 Comment[pt_BR]=Cliente de mensagens instantâneas multi-protocolo
3726
d85208a99af2 [gaim-migrate @ 3862]
Luke Schierer <lschiere@pidgin.im>
parents: 3364
diff changeset
11 Exec=gaim
3364
d4c260bb5b6b [gaim-migrate @ 3383]
Sean Egan <seanegan@gmail.com>
parents: 3246
diff changeset
12 Icon=gaim.png
3726
d85208a99af2 [gaim-migrate @ 3862]
Luke Schierer <lschiere@pidgin.im>
parents: 3364
diff changeset
13 Terminal=false
325
9e7d74bc5474 [gaim-migrate @ 335]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
14 Type=Application
3726
d85208a99af2 [gaim-migrate @ 3862]
Luke Schierer <lschiere@pidgin.im>
parents: 3364
diff changeset
15 Categories=Application;Network;
7168
282887c9e3dc [gaim-migrate @ 7735]
Christian Hammond <chipx86@chipx86.com>
parents: 4663
diff changeset
16 StartupNotify=true