Mercurial > pidgin

annotate HACKING @ 29475:6d2ba42595fe

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
oscar: Fix a race condition that leads to a crash. With SSL enabled, if we start connecting and something calls purple_account_disconnect between when an SSL flap connection is started and when the connection is actually established, it isn't properly cleaned up (and we try to close the flap), which leads to free-after-use. You can simulate this by adding a timeout-triggered disconnect to the end of oscar_connect_to_bos. [02/22/10 17:11:51] <libpurple/oscar> Destroying oscar connection of type 0x0002. Disconnect reason is 0 [02/22/10 17:11:51] <libpurple/oscar> Disconnected. Code is 0x0000 and msg is (hiicq:17126): GLib-WARNING **: giounix.c:400Error while getting flags for FD: Bad file descriptor (9) [02/22/10 17:11:51] <libpurple/oscar> Scheduling destruction of FLAP connection of type 0x0002 [02/22/10 17:11:51] <libpurple/oscar> Signed off. ... [02/22/10 17:11:51] <libpurple/oscar> Destroying oscar connection of type 0x7261. Disconnect reason is 1668179315
author Paul Aurich <paul@darkrain42.org>
date Mon, 22 Feb 2010 17:53:38 +0000
parents d73ee2690376
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
16174
c95641c98e47 Let's just have HACKING point to Trac, okay?
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
1 For information on hacking on Pidgin, Finch, or libpurple, see:
c95641c98e47 Let's just have HACKING point to Trac, okay?
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
2 http://developer.pidgin.im