annotate gaim.desktop.in @ 14624:776615acf309

[gaim-migrate @ 17356] After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption. committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Tue, 26 Sep 2006 17:38:09 +0000
parents 5adc0c9da9f3
children 346faf2a5acd
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
13179
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
1 [Desktop Entry]
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
2 Encoding=UTF-8
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
3 _Name=Gaim Internet Messenger
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
4 _GenericName=Internet Messenger
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
5 _Comment=Send instant messages over multiple protocols
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
6 Exec=gaim
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
7 Icon=gaim.png
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
8 StartupNotify=true
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
9 Terminal=false
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
10 Type=Application
5adc0c9da9f3 [gaim-migrate @ 15542]
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
11 Categories=Application;Network;