annotate PLUGIN_HOWTO @ 29608:8d4bed3021dc

Fix some problems in the oscar code that deals with channel 2 icbms. Specifically related to rtf messages and sent as ICQ server relay. Introduced in 1431506710bed6b8f0c837b670ee314b1692990e in the im.pidgin.cpw.rekkanoryo.icqxstatus branch * memleak fix: We weren't freeing rtfmsg * remote crash fix: We always check args->info.rtfmsg.rtfmsg and try to convert it to UTF-8. However, args->info.rtfmsg is a part of a union and is only set/valid when args->type is OSCAR_CAPABILITY_ICQSERVERRELAY So channel 2 icbms of other types (like chat invites, for example) tend to cause a crash. * possibly printing invalid utf-8: if we could not convert rtfmsg to utf8, and the original rtfmsg failed to validate as utf8, then we tried to write the message to the im window anyway. But that's clearly not a good idea. Really glad I happened to find that remote crash before we released--dealing with security problems is such a pain.
author Mark Doliner <mark@kingant.net>
date Thu, 18 Mar 2010 07:55:17 +0000
parents db5a58aabe38
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
15934
cc3c50816cc9 More gaim->whatever isms
Mark Doliner <mark@kingant.net>
parents: 14505
diff changeset
1 For information on writing a plugin for Purple, Pidgin or Finch, go
28030
db5a58aabe38 Wrap this file more consistently.
Richard Laager <rlaager@wiktel.com>
parents: 16176
diff changeset
2 http://developer.pidgin.im and click on API. From there, see the
db5a58aabe38 Wrap this file more consistently.
Richard Laager <rlaager@wiktel.com>
parents: 16176
diff changeset
3 HOWTOs in the "Related Pages" section.
14505
7acebc9d043f [gaim-migrate @ 17225]
Mark Doliner <mark@kingant.net>
parents:
diff changeset
4
7acebc9d043f [gaim-migrate @ 17225]
Mark Doliner <mark@kingant.net>
parents:
diff changeset
5 You can also generate this documentation locally by installing
15934
cc3c50816cc9 More gaim->whatever isms
Mark Doliner <mark@kingant.net>
parents: 14505
diff changeset
6 doxygen and graphviz dot, then running "make docs" in the
14505
7acebc9d043f [gaim-migrate @ 17225]
Mark Doliner <mark@kingant.net>
parents:
diff changeset
7 source tree. The documentation will be in the docs/html directory.