annotate .cvsignore @ 7652:ac6b2b3a9a1f

[gaim-migrate @ 8296] Bj?rn Voigt (bjoernv) writes: " I found a small problem in Gaim's proxy settings. There is an option "Use Environmental Settings". This option does not work as expected. Gaim reads the environment variables http_proxy (or HTTP_PROXY or HTTPPROXY) and http_proxy_port (or HTTP_PROXY_PORT or HTTPPROXYPORT) and variables for proxy user and proxy password. Gaim expects the following format: export http_proxy=your.proxy.server export http_proxy_port=8080 As far as I know this is a unusual format. Probably there is no standard document, which describes the correct format of proxy variables, but browsers like Konqueror, Amaya, Lynx and others use a pseudo standard format: export http_proxy="http://your.proxy.server:8080/" The port number defaults to 80. The variable http_proxy_port is unknown. The proxy variable format is described in some W3C pages, for instance: http://www.w3.org/Daemon/User/Proxies/ProxyClients.html http://www.w3.org/Library/User/Using/Proxy.html http://www.w3.org/Amaya/User/Proxy.html Solution -------- My patch fixes the proxy environment variable parsing in src/proxy.c:1626: gaim_proxy_connect(). The patch removes http_proxy_port and uses gaim_url_parse() from src/util.c to parse the http_proxy variable. Remaining problems ------------------ If a user has adjusted his proxy settings to Gaim's old proxy variable format, he gets an error. I don't think, that this is a big problem, as not much users set their proxy variables only for one program (old proxy variables where incompatible with browsers like Lynx, Konqueror, ...). Gaim still doesn't look at the no_proxy variable. This variables defines hosts and domains, which should be connected directly: export no_proxy="cern.ch,ncsa.uiuc.edu,some.host:8080" For example, one user may want to connect to Yahoo! over a proxy and to an internal Jabber server without a proxy. But the user can define individual proxy variables for each account." he continues: "Nathan Walp <faceprint@faceprint.com> wrote: > Why not have your patch check to see if the http_proxy var starts with > "http://", and if so, parse it, otherwise fall back on the old behavior. Ok, the function gaim_url_parse() automatically detects hostnames and port numbers, if the http_proxy URL does not start with http://. My new patch also checks for http_proxy_port. Now my patch (file proxy2.patch) is fully backward compatible and tested." given how rarely the current proxy code works, i don't see how this could possibly make things worse, so i'm taking a chance since it compiles. someone please test this. committer: Tailor Script <tailor@pidgin.im>
author Luke Schierer <lschiere@pidgin.im>
date Sat, 29 Nov 2003 03:46:24 +0000
parents cb320b74a0dd
children a0b7b72e278d
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1893
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
1 config.h
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
2 libtool
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
3 config.status
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
4 intl
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
5 ABOUT-NLS
5048
cb320b74a0dd [gaim-migrate @ 5396]
Luke Schierer <lschiere@pidgin.im>
parents: 4704
diff changeset
6 compile
1893
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
7 config.guess
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
8 config.sub
4558
d22814243d13 [gaim-migrate @ 4839]
Christian Hammond <chipx86@chipx86.com>
parents: 4427
diff changeset
9 Doxyfile
1893
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
10 ltconfig
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
11 ltmain.sh
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
12 install-sh
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
13 mkinstalldirs
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
14 missing
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
15 aclocal.m4
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
16 configure
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
17 config.h.in
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
18 stamp-h.in
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
19 Makefile.in
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
20 config.log
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
21 config.cache
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
22 Makefile
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
23 stamp-h
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
24 gaim.spec
2168
74947d32d3c6 [gaim-migrate @ 2178]
Eric Warmenhoven <eric@warmenhoven.org>
parents: 1894
diff changeset
25 depcomp
74947d32d3c6 [gaim-migrate @ 2178]
Eric Warmenhoven <eric@warmenhoven.org>
parents: 1894
diff changeset
26 stamp-h1
3358
092594c175ff [gaim-migrate @ 3377]
Christian Hammond <chipx86@chipx86.com>
parents: 3356
diff changeset
27 autom4te*.cache
3356
8647a5b37b5c [gaim-migrate @ 3375]
Christian Hammond <chipx86@chipx86.com>
parents: 3355
diff changeset
28 configure.2.1x
3358
092594c175ff [gaim-migrate @ 3377]
Christian Hammond <chipx86@chipx86.com>
parents: 3356
diff changeset
29 confdefs.h
092594c175ff [gaim-migrate @ 3377]
Christian Hammond <chipx86@chipx86.com>
parents: 3356
diff changeset
30 *.swp
3702
d82147d95f6b [gaim-migrate @ 3833]
Rob Flynn <gaim@robflynn.com>
parents: 3358
diff changeset
31 win32-install-dir
3703
286e44e665e1 [gaim-migrate @ 3834]
Rob Flynn <gaim@robflynn.com>
parents: 3702
diff changeset
32 .temp-gettextize
4704
56c70997fe5c [gaim-migrate @ 5015]
Nathan Walp <nwalp@pidgin.im>
parents: 4558
diff changeset
33 m4