Mercurial > pidgin
annotate share/Makefile.mingw @ 20982:aee8d876fed1
When getting info on a myspace user not on the buddy list, a temporary
PurpleBuddy is needed so that the data can be associated properly. This
fixes a bug wherein the profile link went to http://myspace.com/0 for all
buddies not on the list. A check against that uid being 0 has also been added
to avoid displaying junk data.
Such temporary MsimUser objects (note that the temporariness of MsimUser
objects is unchanged; a temporary PurpleBuddy has just been added to go with
it) are destroyed before a delayed callback can be triggerred. This means that
we can not request a buddy icon on that object, because we will end up with
a pointer to freed data in the callback some time in the future. This fixes
a crash when getting info on a non-buddy list buddy (which for reasons I can't
pinpoint was most likely if the username contained capital letters).
A reference counting system for MsimUser objects would fix this but is a
significantly more complex solution.
author | Evan Schoenberg <evan.s@dreskin.net> |
---|---|
date | Thu, 18 Oct 2007 12:01:41 +0000 |
parents | ceb6561c5865 |
children |
rev | line source |
---|---|
19193
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
1 # |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
2 # Makefile.mingw |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
3 # |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
4 # Description: Makefile for win32 (mingw) version |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
5 # |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
6 |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
7 PIDGIN_TREE_TOP := .. |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
8 include $(PIDGIN_TREE_TOP)/libpurple/win32/global.mak |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
9 |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
10 include ./Makefile.am |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
11 |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
12 .PHONY: install clean |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
13 |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
14 install: |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
15 if test '$(SUBDIRS)'; then \ |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
16 list='$(SUBDIRS)'; for subdir in $$list; do \ |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
17 $(MAKE) -C $$subdir -f $(MINGW_MAKEFILE) install || exit 1 ;\ |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
18 done; \ |
ceb6561c5865
Fix sounds on the win32 build
Daniel Atallah <daniel.atallah@gmail.com>
parents:
diff
changeset
|
19 fi; |