Mercurial > pidgin
annotate pidgin.desktop.in @ 31070:b39b6d0008c5
upnp: Asynch-ronize the callbacks from UPnP to calling code. Refs #12387
I have no idea if this will resolve the crashes, but with the help of the
packet capture, I /think/ these are correct.
Short summary: it's possible for the callback to fire (and ar be freed) before
the top-level function (purple_upnp_cancel_port_mapping) returns, even though
cancel_port_mapping returns the now-invalid ar (which may lead to a subsequent
use-after-free).
At least one call path through the code that I think leads to this (backed
up by one of the debug logs I looked at):
purple_upnp_cancel_port_mapping(...)
do_port_mapping_cb (has_control_mapping == TRUE, ar->add == FALSE)
purple_upnp_generate_action_message_and_send(..., done_port_mapping_cb, ar)
/* We fail to parse the URL (see some debug logs) */
done_port_mapping_cb
ar->cb(FALSE, cbdata)
return;
return;
return;
return ar;
...and something which calls:
do_port_mapping_cb(has_control_mapping == TRUE, ar->add == TRUE)
ar->cb(FALSE, cbdata)
g_free(ar)
return;
author | Paul Aurich <paul@darkrain42.org> |
---|---|
date | Tue, 28 Dec 2010 05:37:20 +0000 |
parents | 281bd8a973d8 |
children |
rev | line source |
---|---|
15478 | 1 [Desktop Entry] |
2 _Name=Pidgin Internet Messenger | |
3 _GenericName=Internet Messenger | |
28508 | 4 _Comment=Chat over IM. Supports AIM, Google Talk, Jabber/XMPP, MSN, Yahoo and more |
15478 | 5 Exec=pidgin |
16438
ed4ea63c0b45
pidgin.png -> pidgin, to always find appropriate sizes.
Hylke Bons <hylkebons@gmail.com>
parents:
15478
diff
changeset
|
6 Icon=pidgin |
15478 | 7 StartupNotify=true |
8 Terminal=false | |
9 Type=Application | |
10 Categories=Network;InstantMessaging; |