annotate .todo @ 24475:caf82c1cebf2

I've seen this crash a few times where cmd->param_count is 4 and we try to access params[4] which is invalid. The backtrace is: #0 0x0000003c4c4341ca in ____strtoll_l_internal () from /lib64/libc.so.6 #1 0x0000003c4c431ab2 in atoi () from /lib64/libc.so.6 #2 0x00000000005f0abe in ubm_cmd (cmdproc=0xc86eb30, cmd=0xc832e00) at notification.c:494 #3 0x00000000005efef1 in msn_cmdproc_process_cmd (cmdproc=0xc86eb30, cmd=0xc832e00) at cmdproc.c:321 #4 0x00000000005eff97 in msn_cmdproc_process_cmd_text (cmdproc=0xc86eb30, command=0xcadb390 "UBM somebody1@yahoo.com 32 1 170") at cmdproc.c:343 #5 0x00000000005f9d8f in read_cb (data=0xc86ea90, source=9, cond=PURPLE_INPUT_READ) at servconn.c:439 #6 0x00000000004db70c in pidgin_io_invoke (source=0xc8369f0, condition=G_IO_IN, data=0xc836570) at gtkeventloop.cc:79 Here are some other values I've seen for command in frame 4: UBM somebody1@yahoo.com 32 1 170 UBM somebody2@yahoo.com 32 2 91 UBM somebody3@yahoo.com 32 2 93
author Mark Doliner <mark@kingant.net>
date Tue, 18 Nov 2008 07:16:49 +0000
parents 3796304f343d
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
11683
5ec3bd74a3b3 [gaim-migrate @ 13969]
Luke Schierer <lschiere@pidgin.im>
parents: 9929
diff changeset
1 <todo version="0.1.19">
3994
9785ad299331 [gaim-migrate @ 4189]
Luke Schierer <lschiere@pidgin.im>
parents: 3993
diff changeset
2 <title>
9785ad299331 [gaim-migrate @ 4189]
Luke Schierer <lschiere@pidgin.im>
parents: 3993
diff changeset
3 Gaim TODO List
9785ad299331 [gaim-migrate @ 4189]
Luke Schierer <lschiere@pidgin.im>
parents: 3993
diff changeset
4 </title>
16236
4aedcb70cc07 remove some of the outdated todo stuff. most of the TODO file was handled as we worked on 2.0.0. Much of the .todo files was badly out of date, some of it completed, some of it no longer applies though not exactly completed, and other parts of it really rather debatable.
Luke Schierer <lschiere@pidgin.im>
parents: 13500
diff changeset
5 <link filename="./libpurple/protocols/oscar/.todo" priority="medium" time="0"/>
4aedcb70cc07 remove some of the outdated todo stuff. most of the TODO file was handled as we worked on 2.0.0. Much of the .todo files was badly out of date, some of it completed, some of it no longer applies though not exactly completed, and other parts of it really rather debatable.
Luke Schierer <lschiere@pidgin.im>
parents: 13500
diff changeset
6 <link filename="./libpurple/protocols/jabber/.todo" priority="medium" time="1176995038"/>
3833
5ae43f0eeba3 [gaim-migrate @ 3982]
Luke Schierer <lschiere@pidgin.im>
parents:
diff changeset
7 </todo>