Mercurial > pidgin

annotate .mtn-ignore @ 22411:d9105ead88dc

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
When purple_buddy_icons_set_account_icon() is called, it unrefs the old PurpleStoredImage and refs the new one. Previously, it notified the prpl of the change in the buddy icon before updating pointer_icon_cache, which meant that if the prpl then called purple_buddy_icons_find_account_icon() it would get the old PurpleStoredImage (which is at this point not only old but also a pointer to invalid memory if unref'ing it caused it to be destroyed). This happens in jabber_set_info() as of 2.4.0, causing a crash when setting no-buddy-icon for an account after it has previously had an icon. I think this also means that XMPP accounts in 2.4.0 will also always set serverside the *last* icon set, not the current one, when changing icons, but I didn't test that. The solution is simple: Update pointer_icon_cache earlier, setting the new img if there is one or removing the account entirely from the hash table if there isn't one now. This fixes both problems described above, making purple_buddy_icons_find_account_icon() return the new, current icon (or NULL) at all times.
author Evan Schoenberg <evan.s@dreskin.net>
date Tue, 04 Mar 2008 00:11:22 +0000
parents f890c02eee13
children 8b952cb84f45
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
17830
4c454d1a6f85 Set up .mtnignore to ignore the svn directories.
Andreas Monitzer <pidgin@monitzer.com>
parents: 17396
diff changeset
1 (.*/)?\.svn
15394
0453c85a1c51 Updated .mtn-ignore not to ignore new Makefiles and for win32 build stuff.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 15378
diff changeset
2 .*/?Makefile(\.in)?$
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
3 (.*/)?TAGS$
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
4 .*/?.*\.pc$
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
5 .*/perl/common/[^/]+\.c$
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
6 .*/perl/common/blib.*
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
7 .*/perl/common/pm_to_blib$
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
8 .*\.bs$
17342
ecf5bf6daa78 Create .def files for easy msvc import library creation.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 16594
diff changeset
9 .*\.def$
15394
0453c85a1c51 Updated .mtn-ignore not to ignore new Makefiles and for win32 build stuff.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 15378
diff changeset
10 .*\.dll$
0453c85a1c51 Updated .mtn-ignore not to ignore new Makefiles and for win32 build stuff.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 15378
diff changeset
11 .*\.exe$
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
12 intltool-.*
18459
042b64016a57 Patch from Jason Conti to enable `make -f Makefile.mingw docs` on the windows build. Fixes #1801.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 17396
diff changeset
13 Doxyfile(\.mingw)?$
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
14 aclocal.m4
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
15 compile
17395
17c45200927a Add config.cache to .mtn-ignore.
Richard Laager <rlaager@wiktel.com>
parents: 17342
diff changeset
16 config.cache
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
17 config.guess
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
18 config.h$
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
19 config.h.in
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
20 config.log
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
21 config.status
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
22 config.sub
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
23 configure$
20327
01043a291e3b applied changes from 2495a1b6a3619d8188151eaf2822ce2ecd435dbf
Luke Schierer <lschiere@pidgin.im>
parents: 19695
diff changeset
24 finch/finch$
15836
5ee868aceb6d .mtn-ignore updates
Daniel Atallah <daniel.atallah@gmail.com>
parents: 15456
diff changeset
25 finch/libgnt/gntmarshal.c
5ee868aceb6d .mtn-ignore updates
Daniel Atallah <daniel.atallah@gmail.com>
parents: 15456
diff changeset
26 finch/libgnt/gntmarshal.h
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
27 depcomp
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
28 doc/finch.1$
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
29 doc/pidgin.1$
16048
55a80bb5ed51 Update doxygen to generate stuff that works in Trac
Daniel Atallah <daniel.atallah@gmail.com>
parents: 15836
diff changeset
30 doc/html
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
31 pidgin.apspec$
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
32 pidgin.desktop$
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
33 pidgin.spec$
16085
83a17c27b900 Updates to .mtn-ignore
Daniel Atallah <daniel.atallah@gmail.com>
parents: 16048
diff changeset
34 pidgin-.*.tar.gz
16110
0a5470a8fd24 Ignore tar.bz2's too
Stu Tomlinson <stu@nosnilmot.com>
parents: 16085
diff changeset
35 pidgin-.*.tar.bz2
21807
f890c02eee13 Ignore stripped win32 bin directory.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 21789
diff changeset
36 pidgin-*.*.*-win32bin$
17342
ecf5bf6daa78 Create .def files for easy msvc import library creation.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 16594
diff changeset
37 pidgin/pidgin$
19502
c6af18ea22a9 Update .mtn-ignore for emotes size change.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 18459
diff changeset
38 pidgin/pixmaps/emotes/default/24/theme
17396
92821180bded A somewhat-Warmenhoved patch from tfujiwara to allow for the smiley theme
Richard Laager <rlaager@wiktel.com>
parents: 17395
diff changeset
39 pidgin/pixmaps/emotes/none/theme
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
40 pidgin/plugins/musicmessaging/music-messaging-bindings.c
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
41 pidgin/plugins/perl/common/Makefile.PL$
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
42 pidgin/win32/pidgin_dll_rc.rc$
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
43 pidgin/win32/pidgin_exe_rc.rc$
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
44 install-sh
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
45 libpurple/dbus-bindings.c
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
46 libpurple/dbus-types.c
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
47 libpurple/dbus-types.h
16085
83a17c27b900 Updates to .mtn-ignore
Daniel Atallah <daniel.atallah@gmail.com>
parents: 16048
diff changeset
48 libpurple/example/nullclient
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
49 libpurple/gconf/purple.schemas$
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
50 libpurple/plugins/dbus-example-bindings.c
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
51 libpurple/plugins/perl/common/Makefile.PL$
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
52 libpurple/plugins/perl/common/const-c.inc
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
53 libpurple/plugins/perl/common/const-xs.inc
15394
0453c85a1c51 Updated .mtn-ignore not to ignore new Makefiles and for win32 build stuff.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 15378
diff changeset
54 libpurple/plugins/perl/common/lib
21789
cbf778310bdd Ignore the generated purple.h
Stu Tomlinson <stu@nosnilmot.com>
parents: 20327
diff changeset
55 libpurple/purple.h$
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
56 libpurple/purple-client-bindings.c
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
57 libpurple/purple-client-bindings.h
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
58 libpurple/purple-client-example
16206
93f1801d4cc6 Update .mtn-ignore to properly deal with things produced by make check
Richard Laager <rlaager@wiktel.com>
parents: 16139
diff changeset
59 libpurple/tests/check_libpurple
17342
ecf5bf6daa78 Create .def files for easy msvc import library creation.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 16594
diff changeset
60 libpurple/version.h$
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
61 libpurple/win32/libpurplerc.rc$
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
62 libtool
15456
f217a2d656c8 Add support for win32 makefile variable overriding using a "local.mak" file in the build root directory. This makes maintaining a custom build environment or cross-compiling easier.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 15395
diff changeset
63 local.mak
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
64 ltmain.sh
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
65 missing
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
66 mkinstalldirs
15395
eb93d03ed6c7 More ignoration fixes
Ethan Blanton <elb@pidgin.im>
parents: 15394
diff changeset
67 po/Makefile.in.in
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
68 po/POTFILES$
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
69 po/missing
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
70 po/notexist
16206
93f1801d4cc6 Update .mtn-ignore to properly deal with things produced by make check
Richard Laager <rlaager@wiktel.com>
parents: 16139
diff changeset
71 po/pidgin.pot
15378
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
72 po/stamp-it
b2a8c5eca30a Add a .mtn-ignore to silence monotone when builds finally work
Ethan Blanton <elb@pidgin.im>
parents:
diff changeset
73 stamp-h1
15394
0453c85a1c51 Updated .mtn-ignore not to ignore new Makefiles and for win32 build stuff.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 15378
diff changeset
74 win32-install-dir(\.release)?
16139
caab13aa0b5c Apparently the .mtn-ignore patterns are regular expressions. This means
Richard Laager <rlaager@wiktel.com>
parents: 16110
diff changeset
75 VERSION$