Mercurial > pidgin
annotate src/protocols/msn/object.c @ 12645:fc28451f5d96
[gaim-migrate @ 14983]
SF Patch #1314512 from Sadrul (who has a patch for everything)
"This patch introduces a flag for protocol plugins that
support offline messages (like Y!M and ICQ). This was
encouraged by the following conversation:
<sadrul> should offline buddies be listed/enabled in
the send-to menu?
<rekkanoryo> i would think only for protocols that
support offline messaging, if it's indicated that the
buddy is offline
-- <snip> --
<Bleeter> sadrul: personally, I'd like to see a
'supports offline' flag of some description
<Bleeter> one could then redirect (via plugins) through
email or alternative methods
<Bleeter> just a thought
<Paco-Paco> yeah, that sounds like a reasonble thing to have
This patch uses this flag to disable the buddies in the
send-to menu who are offline and the protocol doesn't
support offline messages."
I made this make the label insensitive instead of the whole menuitem. This
should address SimGuy's concerns about inconsistency (i.e. you could create a
conversation with someone via the buddy list that you couldn't create via the
Send To menu). I also hacked up some voodoo to show the label as sensitive when
moused-over, as that looks better (given the label-insensitive thing is itself a
hack). I think this works quite well.
BUG NOTE:
This makes more obvious an existing bug. The Send To menu isn't updated when
buddies sign on or off or change status (at least under some circumstances).
We need to fix that anyway, so I'm not going to let it hold up this commit.
Switching tabs will clear it up. I'm thinking we just might want to build the
contents of that menu when it is selected. That would save us a mess of
inefficient signal callbacks that update the Send To menus in open windows all
the time.
AIM NOTE:
This assumes that AIM can't offline message. That's not strictly true. You can
message invisible users on AIM. However, by design, we can't tell when a user
is invisible without resorting to dirty hackery. In practice, this isn't a
problem, as you can still select the AIM user from the menu. And really, how
often will you be choosing the Invisible contact, rather than the user going
Invisible in the middle of a conversation or IMing you while they're Invisible?
JABBER NOTE:
This assumes that Jabber can always offline message. This isn't strictly true.
Sadrul said:
I have updated Jabber according to this link which seems to
talk about how to determine the existence offline-message
support in a server:
http://www.jabber.org/jeps/jep-0013.html#discover
However, jabber.org doesn't seem to send the required
info. So I am not sure about it.
He later said:
I talked to Nathan and he said offline message support is
mostly assumed for most jabber servers. GTalk doesn't yet
support it, but they are working on it. So I have made
jabber to always return TRUE.
If there is truly no way to detect offline messaging capability, then this is
an acceptable solution. We could special case Google Talk because of its
popularity, and remove that later. It's probably not worth it though.
MSN NOTE:
This assumes that MSN can never offline message. That's effectively true, but
to be technically correct, MSN can offline message if there's already a
switchboard conversation open with a user. We could write an offline_message
function in the MSN prpl to detect that, but it'd be of limited usefulness,
especially given that under most circumstances (where this might matter), the
switchboard connection will be closed almost immediately.
CVS NOTE:
I'm writing to share a tragic little story.
I have a PC that I use for Gaim development. One day, I was writing a commit
message on it, when all of a suddent it went berserk. The screen started
flashing, and the whole commit message just disappeared. All of it. And it was
a good commit message! I had to cram and rewrite it really quickly. Needless to
say, my rushed commit message wasn't nearly as good, and I blame the PC for that.
Seriously, though, what kind of version control system loses your commit
message on a broken connection to the server? Stupid!
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Fri, 23 Dec 2005 19:26:04 +0000 |
parents | fc464a0abccc |
children | 852b32710df0 |
rev | line source |
---|---|
9193 | 1 /** |
2 * @file object.c MSNObject API | |
3 * | |
4 * gaim | |
5 * | |
9198
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
6 * Gaim is the legal property of its developers, whose names are too numerous |
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
7 * to list here. Please refer to the COPYRIGHT file distributed with this |
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
8 * source distribution. |
9193 | 9 * |
10 * This program is free software; you can redistribute it and/or modify | |
11 * it under the terms of the GNU General Public License as published by | |
12 * the Free Software Foundation; either version 2 of the License, or | |
13 * (at your option) any later version. | |
14 * | |
15 * This program is distributed in the hope that it will be useful, | |
16 * but WITHOUT ANY WARRANTY; without even the implied warranty of | |
17 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
18 * GNU General Public License for more details. | |
19 * | |
20 * You should have received a copy of the GNU General Public License | |
21 * along with this program; if not, write to the Free Software | |
22 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
23 */ | |
24 #include "object.h" | |
25 | |
26 #define GET_STRING_TAG(field, id) \ | |
27 if ((tag = strstr(str, id "=\"")) != NULL) \ | |
28 { \ | |
29 tag += strlen(id "=\""); \ | |
30 c = strchr(tag, '"'); \ | |
10116 | 31 if (c != NULL) \ |
32 { \ | |
33 if (obj->field != NULL) \ | |
34 g_free(obj->field); \ | |
35 obj->field = g_strndup(tag, c - tag); \ | |
36 } \ | |
9193 | 37 } |
38 | |
39 #define GET_INT_TAG(field, id) \ | |
40 if ((tag = strstr(str, id "=\"")) != NULL) \ | |
41 { \ | |
42 char buf[16]; \ | |
9823 | 43 size_t offset; \ |
9193 | 44 tag += strlen(id "=\""); \ |
45 c = strchr(tag, '"'); \ | |
9823 | 46 if (c != NULL) \ |
47 { \ | |
48 memset(buf, 0, sizeof(buf)); \ | |
49 offset = c - tag; \ | |
50 if (offset >= sizeof(buf)) \ | |
51 offset = sizeof(buf) - 1; \ | |
52 strncpy(buf, tag, offset); \ | |
53 obj->field = atoi(buf); \ | |
54 } \ | |
9193 | 55 } |
56 | |
57 static GList *local_objs; | |
58 | |
59 MsnObject * | |
60 msn_object_new(void) | |
61 { | |
62 MsnObject *obj; | |
63 | |
64 obj = g_new0(MsnObject, 1); | |
65 | |
66 msn_object_set_type(obj, MSN_OBJECT_UNKNOWN); | |
67 msn_object_set_friendly(obj, "AAA="); | |
68 | |
69 return obj; | |
70 } | |
71 | |
72 MsnObject * | |
73 msn_object_new_from_string(const char *str) | |
74 { | |
75 MsnObject *obj; | |
76 char *tag, *c; | |
77 | |
78 g_return_val_if_fail(str != NULL, NULL); | |
79 g_return_val_if_fail(!strncmp(str, "<msnobj ", 8), NULL); | |
80 | |
81 obj = msn_object_new(); | |
82 | |
83 GET_STRING_TAG(creator, "Creator"); | |
84 GET_INT_TAG(size, "Size"); | |
85 GET_INT_TAG(type, "Type"); | |
86 GET_STRING_TAG(location, "Location"); | |
87 GET_STRING_TAG(friendly, "Friendly"); | |
88 GET_STRING_TAG(sha1d, "SHA1D"); | |
89 GET_STRING_TAG(sha1c, "SHA1C"); | |
90 | |
9776 | 91 /* If we are missing any of the required elements then discard the object */ |
92 if (obj->creator == NULL || obj->size == 0 || obj->type == 0 | |
93 || obj->location == NULL || obj->friendly == NULL | |
94 || obj->sha1d == NULL || obj->sha1c == NULL) { | |
95 msn_object_destroy(obj); | |
96 obj = NULL; | |
97 } | |
98 | |
9193 | 99 return obj; |
100 } | |
101 | |
102 void | |
103 msn_object_destroy(MsnObject *obj) | |
104 { | |
105 g_return_if_fail(obj != NULL); | |
106 | |
107 if (obj->creator != NULL) | |
108 g_free(obj->creator); | |
109 | |
110 if (obj->location != NULL) | |
111 g_free(obj->location); | |
112 | |
10574 | 113 if (obj->real_location != NULL) |
114 g_free(obj->real_location); | |
115 | |
9193 | 116 if (obj->friendly != NULL) |
117 g_free(obj->friendly); | |
118 | |
119 if (obj->sha1d != NULL) | |
120 g_free(obj->sha1d); | |
121 | |
122 if (obj->sha1c != NULL) | |
123 g_free(obj->sha1c); | |
9198
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
124 |
9193 | 125 if (obj->local) |
126 local_objs = g_list_remove(local_objs, obj); | |
127 | |
128 g_free(obj); | |
129 } | |
130 | |
131 char * | |
132 msn_object_to_string(const MsnObject *obj) | |
133 { | |
134 char *str; | |
135 | |
136 g_return_val_if_fail(obj != NULL, NULL); | |
137 | |
138 str = g_strdup_printf("<msnobj Creator=\"%s\" Size=\"%d\" Type=\"%d\" " | |
139 "Location=\"%s\" Friendly=\"%s\" SHA1D=\"%s\" " | |
140 "SHA1C=\"%s\"/>", | |
141 msn_object_get_creator(obj), | |
142 msn_object_get_size(obj), | |
143 msn_object_get_type(obj), | |
144 msn_object_get_location(obj), | |
145 msn_object_get_friendly(obj), | |
146 msn_object_get_sha1d(obj), | |
147 msn_object_get_sha1c(obj)); | |
148 | |
149 return str; | |
150 } | |
151 | |
152 void | |
153 msn_object_set_creator(MsnObject *obj, const char *creator) | |
154 { | |
155 g_return_if_fail(obj != NULL); | |
156 | |
157 if (obj->creator != NULL) | |
158 g_free(obj->creator); | |
159 | |
160 obj->creator = (creator == NULL ? NULL : g_strdup(creator)); | |
161 } | |
162 | |
163 void | |
164 msn_object_set_size(MsnObject *obj, int size) | |
165 { | |
166 g_return_if_fail(obj != NULL); | |
167 | |
168 obj->size = size; | |
169 } | |
170 | |
171 void | |
172 msn_object_set_type(MsnObject *obj, MsnObjectType type) | |
173 { | |
174 g_return_if_fail(obj != NULL); | |
175 | |
176 obj->type = type; | |
177 } | |
178 | |
179 void | |
180 msn_object_set_location(MsnObject *obj, const char *location) | |
181 { | |
182 g_return_if_fail(obj != NULL); | |
183 | |
184 if (obj->location != NULL) | |
185 g_free(obj->location); | |
186 | |
187 obj->location = (location == NULL ? NULL : g_strdup(location)); | |
188 } | |
189 | |
190 void | |
191 msn_object_set_friendly(MsnObject *obj, const char *friendly) | |
192 { | |
193 g_return_if_fail(obj != NULL); | |
194 | |
195 if (obj->friendly != NULL) | |
196 g_free(obj->friendly); | |
197 | |
198 obj->friendly = (friendly == NULL ? NULL : g_strdup(friendly)); | |
199 } | |
200 | |
201 void | |
202 msn_object_set_sha1d(MsnObject *obj, const char *sha1d) | |
203 { | |
204 g_return_if_fail(obj != NULL); | |
205 | |
206 if (obj->sha1d != NULL) | |
207 g_free(obj->sha1d); | |
208 | |
209 obj->sha1d = (sha1d == NULL ? NULL : g_strdup(sha1d)); | |
210 } | |
211 | |
212 void | |
213 msn_object_set_sha1c(MsnObject *obj, const char *sha1c) | |
214 { | |
215 g_return_if_fail(obj != NULL); | |
216 | |
217 if (obj->sha1c != NULL) | |
218 g_free(obj->sha1c); | |
219 | |
220 obj->sha1c = (sha1c == NULL ? NULL : g_strdup(sha1c)); | |
221 } | |
222 | |
223 const char * | |
224 msn_object_get_creator(const MsnObject *obj) | |
225 { | |
226 g_return_val_if_fail(obj != NULL, NULL); | |
227 | |
228 return obj->creator; | |
229 } | |
230 | |
231 int | |
232 msn_object_get_size(const MsnObject *obj) | |
233 { | |
234 g_return_val_if_fail(obj != NULL, 0); | |
235 | |
236 return obj->size; | |
237 } | |
238 | |
239 MsnObjectType | |
240 msn_object_get_type(const MsnObject *obj) | |
241 { | |
242 g_return_val_if_fail(obj != NULL, MSN_OBJECT_UNKNOWN); | |
243 | |
244 return obj->type; | |
245 } | |
246 | |
247 const char * | |
248 msn_object_get_location(const MsnObject *obj) | |
249 { | |
250 g_return_val_if_fail(obj != NULL, NULL); | |
251 | |
252 return obj->location; | |
253 } | |
254 | |
255 const char * | |
256 msn_object_get_friendly(const MsnObject *obj) | |
257 { | |
258 g_return_val_if_fail(obj != NULL, NULL); | |
259 | |
260 return obj->friendly; | |
261 } | |
262 | |
263 const char * | |
264 msn_object_get_sha1d(const MsnObject *obj) | |
265 { | |
266 g_return_val_if_fail(obj != NULL, NULL); | |
267 | |
268 return obj->sha1d; | |
269 } | |
270 | |
271 const char * | |
272 msn_object_get_sha1c(const MsnObject *obj) | |
273 { | |
274 g_return_val_if_fail(obj != NULL, NULL); | |
275 | |
276 return obj->sha1c; | |
277 } | |
278 | |
12323
fc464a0abccc
[gaim-migrate @ 14627]
Richard Laager <rlaager@wiktel.com>
parents:
10574
diff
changeset
|
279 static MsnObject * |
9193 | 280 msn_object_find_local(const char *sha1c) |
281 { | |
282 GList *l; | |
9198
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
283 |
9193 | 284 g_return_val_if_fail(sha1c != NULL, NULL); |
285 | |
286 for (l = local_objs; l != NULL; l = l->next) | |
287 { | |
288 MsnObject *local_obj = l->data; | |
289 | |
290 if (!strcmp(msn_object_get_sha1c(local_obj), sha1c)) | |
291 return local_obj; | |
292 } | |
293 | |
294 return NULL; | |
295 | |
296 } | |
297 | |
298 void | |
299 msn_object_set_local(MsnObject *obj) | |
300 { | |
301 g_return_if_fail(obj != NULL); | |
302 | |
303 obj->local = TRUE; | |
304 | |
305 local_objs = g_list_append(local_objs, obj); | |
306 } | |
307 | |
308 void | |
309 msn_object_set_real_location(MsnObject *obj, const char *real_location) | |
310 { | |
311 g_return_if_fail(obj != NULL); | |
9198
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
312 |
9193 | 313 /* obj->local = TRUE; */ |
314 | |
315 if (obj->real_location != NULL) | |
316 g_free(obj->real_location); | |
317 | |
318 obj->real_location = | |
319 (real_location == NULL ? NULL : g_strdup(real_location)); | |
320 } | |
321 | |
322 const char * | |
323 msn_object_get_real_location(const MsnObject *obj) | |
324 { | |
325 MsnObject *local_obj; | |
9198
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
326 |
9193 | 327 g_return_val_if_fail(obj != NULL, NULL); |
328 | |
329 local_obj = msn_object_find_local(msn_object_get_sha1c(obj)); | |
330 | |
331 if (local_obj != NULL) | |
332 return local_obj->real_location; | |
9198
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
333 |
9193 | 334 return NULL; |
335 } |