comparison libpurple/protocols/myspace/myspace.c @ 17954:016f9b2d6ee0

Increase read buffer size and be more careful about overruns.

17953:bde17299004b

{
    guint bm;
   
    bm = msim_msg_get_integer(msg, "bm");

    switch (bm)
    {
        case MSIM_BM_STATUS:
            return msim_incoming_status(session, msg);
        case MSIM_BM_INSTANT:

    {
        g_hash_table_destroy(body);
        g_return_val_if_fail(uid, FALSE);
    }

	purple_debug_info("msim", "associating uid %d with username %s\n", uid, username);

	buddy = purple_find_buddy(session->account, username);
	if (buddy)
	{
		g_hash_table_foreach(body, msim_store_buddy_info_each, buddy);

    /* Only can handle so much data at once... 
     * If this happens, try recompiling with a higher MSIM_READ_BUF_SIZE.
     * Should be large enough to hold the largest protocol message.
     */
    if (session->rxoff == MSIM_READ_BUF_SIZE)
    {
        purple_debug_error("msim", "msim_input_cb: %d-byte read buffer full!\n",
                MSIM_READ_BUF_SIZE);
        purple_connection_error(gc, _("Read buffer full"));
        return;
    }

    purple_debug_info("msim", "buffer at %d (max %d), reading up to %d\n",

    else if (n == 0)
    {
        purple_debug_info("msim", "msim_input_cb: server disconnected\n");
        purple_connection_error(gc, _("Server has disconnected"));
        return;
    }

    /* Null terminate */
    purple_debug_info("msim", "msim_input_cb: going to null terminate "
            "at n=%d\n", n);

17954:016f9b2d6ee0

{
    guint bm;
   
    bm = msim_msg_get_integer(msg, "bm");

    if (msim_msg_get(msg, "cv"))
    {
        purple_debug_info("msim_incoming_bm", "cv=%s",
                msim_msg_get_string(msg, "cv"));
    }

    switch (bm)
    {
        case MSIM_BM_STATUS:
            return msim_incoming_status(session, msg);
        case MSIM_BM_INSTANT:

    {
        g_hash_table_destroy(body);
        g_return_val_if_fail(uid, FALSE);
    }

	purple_debug_info("msim", "associating uid %s with username %s\n", uid, username);

	buddy = purple_find_buddy(session->account, username);
	if (buddy)
	{
		g_hash_table_foreach(body, msim_store_buddy_info_each, buddy);

    /* Only can handle so much data at once... 
     * If this happens, try recompiling with a higher MSIM_READ_BUF_SIZE.
     * Should be large enough to hold the largest protocol message.
     */
    if (session->rxoff >= MSIM_READ_BUF_SIZE)
    {
        purple_debug_error("msim", 
                "msim_input_cb: %d-byte read buffer full! rxoff=%d\n",
                MSIM_READ_BUF_SIZE, session->rxoff);
        purple_connection_error(gc, _("Read buffer full"));
        return;
    }

    purple_debug_info("msim", "buffer at %d (max %d), reading up to %d\n",

    else if (n == 0)
    {
        purple_debug_info("msim", "msim_input_cb: server disconnected\n");
        purple_connection_error(gc, _("Server has disconnected"));
        return;
    }

    if (n + session->rxoff >= MSIM_READ_BUF_SIZE)
    {
        purple_debug_info("msim_input_cb", "received %d bytes, pushing rxoff to %d, over buffer size of %d\n",
                n, n + session->rxoff, MSIM_READ_BUF_SIZE);
        purple_connection_error(gc, _("Read buffer full"));
    }

    /* Null terminate */
    purple_debug_info("msim", "msim_input_cb: going to null terminate "
            "at n=%d\n", n);