Mercurial > pidgin
comparison src/protocols/oscar/buddylist.c @ 3952:07283934dedd
[gaim-migrate @ 4133]
Ok, big commit with little functionality change.
Most of it is me shuffling crap around because I'm one of them neat freaks. Lots of general code
cleanup too. I'm trying to move to that whole "one-family-per-file" thing.
The details...
I added libfaim support for aim's new search family, 0x000f. I only tested this briefly, so if
anyone uses it for anything, be aware that it could be buggy. I'll add oscar support sometime.
Advantages of this family are... when you search for someone, you get the directory info for that
person. So like, first name, middle name, last name, maiden name, city, state, country, zip,
address, interests, nickname, and maybe some other stuff. Basically all the info that they've set in
their directory info thing. Info. Oh, and I'm calling it "new search" because seach was already
taken, and cookie monster ate my right brain.
The reason I didn't add support to oscar.c... the new search family requires making a connection to
another server. While moving stuff around I realized that I didn't really like how new connections
are made. It's kind of sloppy. I'm thinking it would be nice to have an outgoing queue for each
type of connection, and then let the client queue messages as much as they want. Then, if libfaim
sees that there is a message for a certain type of connection, and there is no open connection of
that type, it will connect, and then flush the queue when the connection is made. This seems a lot
cleaner, but it also seems like a pain in the ass. I should do ssi for icq first, anyway :-)
Also, I think it would be neat if there was an ICBM file that handled channels 1 through 4. Then
im.c and chat.c could pass the ICBM part to the icbm stuff and it could get parsed there. im.c is
really huge right now.
I applied a patch from Graham Booker that paves the way for unicode in direct IMs. Thanks Graham.
Now we just need Paco-Paco to git a little free time and write a patch for this.
http://sourceforge.net/tracker/index.php?func=detail&aid=633589&group_id=235&atid=300235
I applied 2 patches from Will Mahan dealing with file transfer/oft/rendezous/whatever. Here's some
info on them, from The Man himself:
Patch 1
"Currently the Rendezvous code is rather messy; this
patch attempts to bring it up to speed with the rest of
the Oscar prpl. Its changes include:
* Rewrite several ft.c functions to use bstreams.
Apparently the code in question was written before
bstreams were implemented.
* Handle incoming Rendezvous packets through the
rxqueue like FLAP packets, rather than handling them as
a special case as soon as they are received. This
takes advantage of the bstream cleanup to unify some
code and simplify the aim_frame_t struct.
* Change some names used to try to clarify the
distinction between OFT, which refers specifically to
file transfer, and Rendezvous, which encompasses OFT as
well as other types of client-to-client connections."
Patch 2
"* Add some comments I inadvertently left out of my last patch.
* Fix a double-free that occurs when connections time out.
* Correct a bug causing filenames to be truncated by 4 characters on
some clients.
* Preserve directory structure when sending multiple files.
* Handle (throw away) resource forks sent by Mac clients."
I also changed all indents to tabs in ft.c.
And split all the bstream stuff from rxqueue.c and put it in bstream.c. It really is a separate
thing. Especially since it can be used for outgoing connections.
Also, I was going to look over the whole patch tonight to make sure it's all good, but it's like 6000
lines, so, uh, I'll do it later.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Wed, 13 Nov 2002 07:01:37 +0000 |
parents | 7ed9fa994055 |
children | 2532f1192da3 |
comparison
equal
deleted
inserted
replaced
3951:32942c49dced | 3952:07283934dedd |
---|---|
1 /* | |
2 * Family 0x0003 - Old-style Buddylist Management (non-SSI). | |
3 * | |
4 */ | |
1 | 5 |
2 #define FAIM_INTERNAL | 6 #define FAIM_INTERNAL |
3 #include <aim.h> | 7 #include <aim.h> |
4 | 8 |
5 /* | 9 /* |
6 * Oncoming Buddy notifications contain a subset of the | 10 * Subtype 0x0002 - Request rights. |
7 * user information structure. Its close enough to run | 11 * |
8 * through aim_extractuserinfo() however. | 12 * Request Buddy List rights. |
9 * | 13 * |
10 * Although the offgoing notification contains no information, | 14 */ |
11 * it is still in a format parsable by extractuserinfo. | 15 faim_export int aim_bos_reqbuddyrights(aim_session_t *sess, aim_conn_t *conn) |
12 * | 16 { |
13 */ | 17 return aim_genericreq_n(sess, conn, 0x0003, 0x0002); |
14 static int buddychange(aim_session_t *sess, aim_module_t *mod, aim_frame_t *rx, aim_modsnac_t *snac, aim_bstream_t *bs) | 18 } |
15 { | 19 |
16 aim_userinfo_t userinfo; | 20 /* |
17 aim_rxcallback_t userfunc; | 21 * Subtype 0x0003 - Rights. |
18 | 22 * |
19 aim_extractuserinfo(sess, bs, &userinfo); | 23 */ |
20 | |
21 if ((userfunc = aim_callhandler(sess, rx->conn, snac->family, snac->subtype))) | |
22 return userfunc(sess, rx, &userinfo); | |
23 | |
24 return 0; | |
25 } | |
26 | |
27 static int rights(aim_session_t *sess, aim_module_t *mod, aim_frame_t *rx, aim_modsnac_t *snac, aim_bstream_t *bs) | 24 static int rights(aim_session_t *sess, aim_module_t *mod, aim_frame_t *rx, aim_modsnac_t *snac, aim_bstream_t *bs) |
28 { | 25 { |
29 aim_rxcallback_t userfunc; | 26 aim_rxcallback_t userfunc; |
30 aim_tlvlist_t *tlvlist; | 27 aim_tlvlist_t *tlvlist; |
31 fu16_t maxbuddies = 0, maxwatchers = 0; | 28 fu16_t maxbuddies = 0, maxwatchers = 0; |
65 aim_freetlvchain(&tlvlist); | 62 aim_freetlvchain(&tlvlist); |
66 | 63 |
67 return ret; | 64 return ret; |
68 } | 65 } |
69 | 66 |
67 /* | |
68 * Subtype 0x0004 - Add buddy to list. | |
69 * | |
70 * Adds a single buddy to your buddy list after login. | |
71 * XXX This should just be an extension of setbuddylist() | |
72 * | |
73 */ | |
74 faim_export int aim_add_buddy(aim_session_t *sess, aim_conn_t *conn, const char *sn) | |
75 { | |
76 aim_frame_t *fr; | |
77 aim_snacid_t snacid; | |
78 | |
79 if (!sn || !strlen(sn)) | |
80 return -EINVAL; | |
81 | |
82 if (!(fr = aim_tx_new(sess, conn, AIM_FRAMETYPE_FLAP, 0x02, 10+1+strlen(sn)))) | |
83 return -ENOMEM; | |
84 | |
85 snacid = aim_cachesnac(sess, 0x0003, 0x0004, 0x0000, sn, strlen(sn)+1); | |
86 aim_putsnac(&fr->data, 0x0003, 0x0004, 0x0000, snacid); | |
87 | |
88 aimbs_put8(&fr->data, strlen(sn)); | |
89 aimbs_putraw(&fr->data, sn, strlen(sn)); | |
90 | |
91 aim_tx_enqueue(sess, fr); | |
92 | |
93 return 0; | |
94 } | |
95 | |
96 /* | |
97 * Subtype 0x0004 - Add multiple buddies to your buddy list. | |
98 * | |
99 * This just builds the "set buddy list" command then queues it. | |
100 * | |
101 * buddy_list = "Screen Name One&ScreenNameTwo&"; | |
102 * | |
103 * XXX Clean this up. | |
104 * | |
105 */ | |
106 faim_export int aim_bos_setbuddylist(aim_session_t *sess, aim_conn_t *conn, const char *buddy_list) | |
107 { | |
108 aim_frame_t *fr; | |
109 aim_snacid_t snacid; | |
110 int len = 0; | |
111 char *localcpy = NULL; | |
112 char *tmpptr = NULL; | |
113 | |
114 if (!buddy_list || !(localcpy = strdup(buddy_list))) | |
115 return -EINVAL; | |
116 | |
117 for (tmpptr = strtok(localcpy, "&"); tmpptr; ) { | |
118 faimdprintf(sess, 2, "---adding: %s (%d)\n", tmpptr, strlen(tmpptr)); | |
119 len += 1 + strlen(tmpptr); | |
120 tmpptr = strtok(NULL, "&"); | |
121 } | |
122 | |
123 if (!(fr = aim_tx_new(sess, conn, AIM_FRAMETYPE_FLAP, 0x02, 10+len))) | |
124 return -ENOMEM; | |
125 | |
126 snacid = aim_cachesnac(sess, 0x0003, 0x0004, 0x0000, NULL, 0); | |
127 aim_putsnac(&fr->data, 0x0003, 0x0004, 0x0000, snacid); | |
128 | |
129 strncpy(localcpy, buddy_list, strlen(buddy_list) + 1); | |
130 | |
131 for (tmpptr = strtok(localcpy, "&"); tmpptr; ) { | |
132 | |
133 faimdprintf(sess, 2, "---adding: %s (%d)\n", tmpptr, strlen(tmpptr)); | |
134 | |
135 aimbs_put8(&fr->data, strlen(tmpptr)); | |
136 aimbs_putraw(&fr->data, tmpptr, strlen(tmpptr)); | |
137 tmpptr = strtok(NULL, "&"); | |
138 } | |
139 | |
140 aim_tx_enqueue(sess, fr); | |
141 | |
142 free(localcpy); | |
143 | |
144 return 0; | |
145 } | |
146 | |
147 /* | |
148 * Subtype 0x0005 - Remove buddy from list. | |
149 * | |
150 * XXX generalise to support removing multiple buddies (basically, its | |
151 * the same as setbuddylist() but with a different snac subtype). | |
152 * | |
153 */ | |
154 faim_export int aim_remove_buddy(aim_session_t *sess, aim_conn_t *conn, const char *sn) | |
155 { | |
156 aim_frame_t *fr; | |
157 aim_snacid_t snacid; | |
158 | |
159 if (!sn || !strlen(sn)) | |
160 return -EINVAL; | |
161 | |
162 if (!(fr = aim_tx_new(sess, conn, AIM_FRAMETYPE_FLAP, 0x02, 10+1+strlen(sn)))) | |
163 return -ENOMEM; | |
164 | |
165 snacid = aim_cachesnac(sess, 0x0003, 0x0005, 0x0000, sn, strlen(sn)+1); | |
166 aim_putsnac(&fr->data, 0x0003, 0x0005, 0x0000, snacid); | |
167 | |
168 aimbs_put8(&fr->data, strlen(sn)); | |
169 aimbs_putraw(&fr->data, sn, strlen(sn)); | |
170 | |
171 aim_tx_enqueue(sess, fr); | |
172 | |
173 return 0; | |
174 } | |
175 | |
176 /* | |
177 * Subtype 0x000b | |
178 * | |
179 * XXX Why would we send this? | |
180 * | |
181 */ | |
182 faim_export int aim_sendbuddyoncoming(aim_session_t *sess, aim_conn_t *conn, aim_userinfo_t *info) | |
183 { | |
184 aim_frame_t *fr; | |
185 aim_snacid_t snacid; | |
186 | |
187 if (!sess || !conn || !info) | |
188 return -EINVAL; | |
189 | |
190 if (!(fr = aim_tx_new(sess, conn, AIM_FRAMETYPE_FLAP, 0x02, 1152))) | |
191 return -ENOMEM; | |
192 | |
193 snacid = aim_cachesnac(sess, 0x0003, 0x000b, 0x0000, NULL, 0); | |
194 | |
195 aim_putsnac(&fr->data, 0x0003, 0x000b, 0x0000, snacid); | |
196 aim_putuserinfo(&fr->data, info); | |
197 | |
198 aim_tx_enqueue(sess, fr); | |
199 | |
200 return 0; | |
201 } | |
202 | |
203 /* | |
204 * Subtype 0x000c | |
205 * | |
206 * XXX Why would we send this? | |
207 * | |
208 */ | |
209 faim_export int aim_sendbuddyoffgoing(aim_session_t *sess, aim_conn_t *conn, const char *sn) | |
210 { | |
211 aim_frame_t *fr; | |
212 aim_snacid_t snacid; | |
213 | |
214 if (!sess || !conn || !sn) | |
215 return -EINVAL; | |
216 | |
217 if (!(fr = aim_tx_new(sess, conn, AIM_FRAMETYPE_FLAP, 0x02, 10+1+strlen(sn)))) | |
218 return -ENOMEM; | |
219 | |
220 snacid = aim_cachesnac(sess, 0x0003, 0x000c, 0x0000, NULL, 0); | |
221 | |
222 aim_putsnac(&fr->data, 0x0003, 0x000c, 0x0000, snacid); | |
223 aimbs_put8(&fr->data, strlen(sn)); | |
224 aimbs_putraw(&fr->data, sn, strlen(sn)); | |
225 | |
226 aim_tx_enqueue(sess, fr); | |
227 | |
228 return 0; | |
229 } | |
230 | |
231 /* | |
232 * Subtypes 0x000b and 0x000c - Change in buddy status | |
233 * | |
234 * Oncoming Buddy notifications contain a subset of the | |
235 * user information structure. Its close enough to run | |
236 * through aim_extractuserinfo() however. | |
237 * | |
238 * Although the offgoing notification contains no information, | |
239 * it is still in a format parsable by extractuserinfo. | |
240 * | |
241 */ | |
242 static int buddychange(aim_session_t *sess, aim_module_t *mod, aim_frame_t *rx, aim_modsnac_t *snac, aim_bstream_t *bs) | |
243 { | |
244 aim_userinfo_t userinfo; | |
245 aim_rxcallback_t userfunc; | |
246 | |
247 aim_extractuserinfo(sess, bs, &userinfo); | |
248 | |
249 if ((userfunc = aim_callhandler(sess, rx->conn, snac->family, snac->subtype))) | |
250 return userfunc(sess, rx, &userinfo); | |
251 | |
252 return 0; | |
253 } | |
254 | |
70 static int snachandler(aim_session_t *sess, aim_module_t *mod, aim_frame_t *rx, aim_modsnac_t *snac, aim_bstream_t *bs) | 255 static int snachandler(aim_session_t *sess, aim_module_t *mod, aim_frame_t *rx, aim_modsnac_t *snac, aim_bstream_t *bs) |
71 { | 256 { |
72 | 257 |
73 if (snac->subtype == 0x0003) | 258 if (snac->subtype == 0x0003) |
74 return rights(sess, mod, rx, snac, bs); | 259 return rights(sess, mod, rx, snac, bs); |
89 strncpy(mod->name, "buddylist", sizeof(mod->name)); | 274 strncpy(mod->name, "buddylist", sizeof(mod->name)); |
90 mod->snachandler = snachandler; | 275 mod->snachandler = snachandler; |
91 | 276 |
92 return 0; | 277 return 0; |
93 } | 278 } |
94 | |
95 /* | |
96 * aim_add_buddy() | |
97 * | |
98 * Adds a single buddy to your buddy list after login. | |
99 * | |
100 * XXX this should just be an extension of setbuddylist() | |
101 * | |
102 */ | |
103 faim_export int aim_add_buddy(aim_session_t *sess, aim_conn_t *conn, const char *sn) | |
104 { | |
105 aim_frame_t *fr; | |
106 aim_snacid_t snacid; | |
107 | |
108 if (!sn || !strlen(sn)) | |
109 return -EINVAL; | |
110 | |
111 if (!(fr = aim_tx_new(sess, conn, AIM_FRAMETYPE_FLAP, 0x02, 10+1+strlen(sn)))) | |
112 return -ENOMEM; | |
113 | |
114 snacid = aim_cachesnac(sess, 0x0003, 0x0004, 0x0000, sn, strlen(sn)+1); | |
115 aim_putsnac(&fr->data, 0x0003, 0x0004, 0x0000, snacid); | |
116 | |
117 aimbs_put8(&fr->data, strlen(sn)); | |
118 aimbs_putraw(&fr->data, sn, strlen(sn)); | |
119 | |
120 aim_tx_enqueue(sess, fr); | |
121 | |
122 return 0; | |
123 } | |
124 | |
125 /* | |
126 * XXX generalise to support removing multiple buddies (basically, its | |
127 * the same as setbuddylist() but with a different snac subtype). | |
128 * | |
129 */ | |
130 faim_export int aim_remove_buddy(aim_session_t *sess, aim_conn_t *conn, const char *sn) | |
131 { | |
132 aim_frame_t *fr; | |
133 aim_snacid_t snacid; | |
134 | |
135 if (!sn || !strlen(sn)) | |
136 return -EINVAL; | |
137 | |
138 if (!(fr = aim_tx_new(sess, conn, AIM_FRAMETYPE_FLAP, 0x02, 10+1+strlen(sn)))) | |
139 return -ENOMEM; | |
140 | |
141 snacid = aim_cachesnac(sess, 0x0003, 0x0005, 0x0000, sn, strlen(sn)+1); | |
142 aim_putsnac(&fr->data, 0x0003, 0x0005, 0x0000, snacid); | |
143 | |
144 aimbs_put8(&fr->data, strlen(sn)); | |
145 aimbs_putraw(&fr->data, sn, strlen(sn)); | |
146 | |
147 aim_tx_enqueue(sess, fr); | |
148 | |
149 return 0; | |
150 } | |
151 |