Mercurial > pidgin
comparison libpurple/protocols/msn/slp.c @ 28800:139aa186e8cc
Don't call purple_xfer_start in msn_xfer_init. purple_xfer_start is called
later after the other side accepts, and this second call clobbers the file
handle. This file handle is leaked resulting in Pidgin appearing to lock
the file stopping Windows from being able to delete it.
The changes from darkrain42's branch actually fixed the real file handle
leak except for the addition of this one line.
Fixes #1643.
| author | Elliott Sales de Andrade <qulogic@pidgin.im> |
|---|---|
| date | Mon, 14 Dec 2009 06:50:33 +0000 |
| parents | 5d8867f11f0d |
| children | 091797665df5 |
comparison
equal
deleted
inserted
replaced
| 28799:bcea7c92d3f1 | 28800:139aa186e8cc |
|---|---|
| 94 send_ok(slpcall, slpcall->branch, "application/x-msnmsgr-sessionreqbody", | 94 send_ok(slpcall, slpcall->branch, "application/x-msnmsgr-sessionreqbody", |
| 95 content); | 95 content); |
| 96 | 96 |
| 97 g_free(content); | 97 g_free(content); |
| 98 msn_slplink_send_queued_slpmsgs(slpcall->slplink); | 98 msn_slplink_send_queued_slpmsgs(slpcall->slplink); |
| 99 | |
| 100 purple_xfer_start(xfer, -1, NULL, 0); | |
| 101 } | 99 } |
| 102 | 100 |
| 103 void | 101 void |
| 104 msn_xfer_cancel(PurpleXfer *xfer) | 102 msn_xfer_cancel(PurpleXfer *xfer) |
| 105 { | 103 { |