Mercurial > pidgin

comparison COPYRIGHT @ 8672:142108e89399

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[gaim-migrate @ 9424] "This patch contains two fixes. The first is rather trivial, just removes the declaration of extra pointer used for deleting a message and deletes the message directly. The second is the real bug that needed fixing. Short Explanation: The old code only fixed the message that was being displayed, and still sent the original unchecked message to the receiving party. All I did was add a handler to the load_plugin function to make it fix the message being sent as well. Longer Explanation: In my cursory look through the gaim code (warning, <15 minutes) it appears the message pointer send to all the various *-im-msg and *-chat-msg handlers is a copy of the original string each time. This means if you fix the string at one stage (displaying), you have to fix it again at the next (sending). This seems rather inefficient, but hey, it's your client, maybe it was a design feature. Anyway, the spellchk plugin was only fixing the displayed message, and not the message being sent. So I thought my messages were being fixed while those receiving them new I was screwing up. I added substitute_somethingorother handler for the sending-im-msg callback in the load_plugin function. Other comments: I didn't look to deeply into it since it's so late, but the "displaying-chat-msg" and "sending-chat-msg" callbacks appear to be broken. The spellchk.c currently has a handler registered for the first callback, but the message displayed on my screen still contains the original typos. If I try to register a handler for the second callback listed, Gaim crashes when sending the message to a chat window. As I said, I didn't look into why it was crashing, I just removed my attempt to handle it and built this patch." --Matt Brenneke committer: Tailor Script <tailor@pidgin.im>
author Luke Schierer <lschiere@pidgin.im>
date Fri, 16 Apr 2004 14:39:34 +0000
parents f95edb58087c
children aebfa2b6af6b
comparison
equal deleted inserted replaced
8671:d99d2572d1a9 8672:142108e89399
15 Herman Bloggs 15 Herman Bloggs
16 Jason Boerner 16 Jason Boerner
17 Graham Booker 17 Graham Booker
18 Craig Boston 18 Craig Boston
19 Chris Boyle 19 Chris Boyle
20 Matt Brenneke
20 Jeremy Brooks 21 Jeremy Brooks
21 Philip Brown 22 Philip Brown
22 Sean Burke 23 Sean Burke
23 Cerulean Studios, LLC 24 Cerulean Studios, LLC
24 Ka-Hing Cheung 25 Ka-Hing Cheung