comparison libpurple/protocols/yahoo/yahoo_doodle.c @ 30432:1cdae196aac8

Standardize on "cancelled". QuLogic: so, canceled or cancelled? that patch on #12130 is pretty thorough... wabz: cancelled :D wabz: that cancelled thing actually bothered me in the past wabz: never quite enough to do such a patch :p elb: that's an en_US vs en_GB thing elb: both are correct, but canceled is more common in en_{US,CA} and cancelled in en_{GB,AU,NZ,etc.} elb: personally, I use cancelled QuLogic: yea, that's what I went for before, but I think I couldn't change any strings because we were frozen QuLogic: you all had to pick the spelling that was opposite from the guy's patch, didn't you... rekkanoryo: well, considering we're generally en_US in our strings, it should be canceled in our source elb: considering they're both correct, and while I'm anal retentive, I'm not anal retentive about that, I have no preference ;-) rekkanoryo: I don't really care either way, I just think that we should be consistently en_US or en_GB throughout elb: right elb: my point is, they're both correct for en_US elb: one 'l' is simply more common rekkanoryo: ah rekkanoryo: if they're both technically correct for en_US, then "cancelled" is my vote rekkanoryo: one 'l' always looks wrong to me elb: the dictionary claims they are Sorry, dwc. Closes #12130.
author Elliott Sales de Andrade <qulogic@pidgin.im>
date Mon, 23 Aug 2010 01:41:31 +0000
parents 908be3822215
children fcf841ffd620 3828a61c44da
comparison
equal deleted inserted replaced
30431:c9a57878ed17 30432:1cdae196aac8
370 if(wb == NULL) 370 if(wb == NULL)
371 return; 371 return;
372 372
373 /* TODO Ask if user wants to save picture before the session is closed */ 373 /* TODO Ask if user wants to save picture before the session is closed */
374 374
375 wb->state = DOODLE_STATE_CANCELED; 375 wb->state = DOODLE_STATE_CANCELLED;
376 purple_whiteboard_destroy(wb); 376 purple_whiteboard_destroy(wb);
377 } 377 }
378 378
379 static void yahoo_doodle_command_send_generic(const char *type, 379 static void yahoo_doodle_command_send_generic(const char *type,
380 PurpleConnection *gc, 380 PurpleConnection *gc,
458 PurpleConnection *gc = purple_account_get_connection(wb->account); 458 PurpleConnection *gc = purple_account_get_connection(wb->account);
459 doodle_session *ds = wb->proto_data; 459 doodle_session *ds = wb->proto_data;
460 460
461 /* g_debug_debug("yahoo", "doodle: yahoo_doodle_end()\n"); */ 461 /* g_debug_debug("yahoo", "doodle: yahoo_doodle_end()\n"); */
462 462
463 if (gc && wb->state != DOODLE_STATE_CANCELED) 463 if (gc && wb->state != DOODLE_STATE_CANCELLED)
464 yahoo_doodle_command_send_shutdown(gc, wb->who); 464 yahoo_doodle_command_send_shutdown(gc, wb->who);
465 465
466 g_free(ds->imv_key); 466 g_free(ds->imv_key);
467 g_free(wb->proto_data); 467 g_free(wb->proto_data);
468 } 468 }