comparison libpurple/protocols/jabber/presence.c @ 22781:2404b13940e9

Fix a crash in Jabber that I think happens someone someone signs off immediately after your client requests capability info about them. The callback is called and passed a reference to the old jbr, but the jbr no longer exists.

22780:46ab2e2171b8

	}
}

typedef struct _JabberPresenceCapabilities {
	JabberStream *js;
	JabberBuddyResource *jbr;
	char *from;
} JabberPresenceCapabilities;

static void jabber_presence_set_capabilities(JabberCapsClientInfo *info, gpointer user_data) {
	JabberPresenceCapabilities *userdata = user_data;
	GList *iter;

	if(userdata->jbr->caps)
		jabber_caps_free_clientinfo(userdata->jbr->caps);
	userdata->jbr->caps = info;

	if (info) {
		for(iter = info->features; iter; iter = g_list_next(iter)) {
			if(!strcmp((const char*)iter->data, "http://jabber.org/protocol/commands")) {
				JabberIq *iq = jabber_iq_new_query(userdata->js, JABBER_IQ_GET, "http://jabber.org/protocol/disco#items");

				const char *ext = xmlnode_get_attrib(caps,"ext");
				
				if(node && ver) {
					JabberPresenceCapabilities *userdata = g_new0(JabberPresenceCapabilities, 1);
					userdata->js = js;
					userdata->jbr = jbr;
					userdata->from = g_strdup(from);
					jabber_caps_get_info(js, from, node, ver, ext, jabber_presence_set_capabilities, userdata);
				}
			}
		}

22781:2404b13940e9

	}
}

typedef struct _JabberPresenceCapabilities {
	JabberStream *js;
	JabberBuddy *jb;
	char *from;
} JabberPresenceCapabilities;

static void jabber_presence_set_capabilities(JabberCapsClientInfo *info, gpointer user_data) {
	JabberPresenceCapabilities *userdata = user_data;
	JabberID *jid;
	JabberBuddyResource *jbr;
	GList *iter;

	jid = jabber_id_new(userdata->from);
	jbr = jabber_buddy_find_resource(userdata->jb, jid->resource);
	jabber_id_free(jid);

	if(!jbr) {
		g_free(userdata->from);
		g_free(userdata);
		return;
	}

	if(jbr->caps)
		jabber_caps_free_clientinfo(jbr->caps);
	jbr->caps = info;

	if (info) {
		for(iter = info->features; iter; iter = g_list_next(iter)) {
			if(!strcmp((const char*)iter->data, "http://jabber.org/protocol/commands")) {
				JabberIq *iq = jabber_iq_new_query(userdata->js, JABBER_IQ_GET, "http://jabber.org/protocol/disco#items");

				const char *ext = xmlnode_get_attrib(caps,"ext");
				
				if(node && ver) {
					JabberPresenceCapabilities *userdata = g_new0(JabberPresenceCapabilities, 1);
					userdata->js = js;
					userdata->jb = jb;
					userdata->from = g_strdup(from);
					jabber_caps_get_info(js, from, node, ver, ext, jabber_presence_set_capabilities, userdata);
				}
			}
		}