comparison libpurple/protocols/yahoo/yahoo_picture.c @ 16685:34618fedf5b9

Update the comments about yahoo buddy icons. Only send the filename and not the whole path.

16684:a0cae757170f

		const char *oldurl = purple_account_get_string(account, YAHOO_PICURL_SETTING, NULL);
		char *iconfile;

		/* TODO: At some point, it'd be nice to fix this for real, or
		 * TODO: at least change it to be something like:
		 * TODO: purple_imgstore_get_filename(img); */
		yd->picture_checksum = g_string_hash(s);

		if ((yd->picture_checksum == oldcksum) &&
			(expire > (time(NULL) + 60*60*24)) && oldurl)
		{

			g_free(yd->picture_url);
			yd->picture_url = g_strdup(oldurl);
			return;
		}

		/* TODO: FIXME: This is completely wrong.  The upload code needs to
		 * TODO: be modified to work with a PurpleStoredImage. */
		iconfile = g_build_filename(purple_buddy_icons_get_cache_dir(),
		                            purple_imgstore_get_filename(img), NULL);
		d = g_new0(struct yahoo_buddy_icon_upload_data, 1);
		d->gc = gc;
		d->str = s;
		d->fd = -1;
		d->filename = iconfile;

16685:34618fedf5b9

		const char *oldurl = purple_account_get_string(account, YAHOO_PICURL_SETTING, NULL);
		char *iconfile;

		/* TODO: At some point, it'd be nice to fix this for real, or
		 * TODO: at least change it to be something like:
		 * TODO: purple_imgstore_get_filename(img);
		 * TODO: But it would be great if we knew how to calculate the
		 * TODO: Checksum correctly. */
		yd->picture_checksum = g_string_hash(s);

		if ((yd->picture_checksum == oldcksum) &&
			(expire > (time(NULL) + 60*60*24)) && oldurl)
		{

			g_free(yd->picture_url);
			yd->picture_url = g_strdup(oldurl);
			return;
		}

		/* We use this solely for sending a filename to the server */
		iconfile = g_strdup(purple_imgstore_get_filename(img));
		d = g_new0(struct yahoo_buddy_icon_upload_data, 1);
		d->gc = gc;
		d->str = s;
		d->fd = -1;
		d->filename = iconfile;