Mercurial > pidgin
comparison libpurple/protocols/yahoo/yahoo.c @ 26568:3712d32363dd
Remove a bug where host_ip was accessed after freeing it.
This should prevent yahoo prpl crashes. I wonder how such a simple mistake escaped me for so long.
| author | Sulabh Mahajan <sulabh@soc.pidgin.im> |
|---|---|
| date | Wed, 15 Apr 2009 15:46:31 +0000 |
| parents | 98d8c336234d |
| children | 25e01fe7b732 ce876e58cf6a |
comparison
equal
deleted
inserted
replaced
| 26567:d00a8111e479 | 26568:3712d32363dd |
|---|---|
| 2971 p2p_data->connection_type = YAHOO_P2P_WE_ARE_CLIENT; | 2971 p2p_data->connection_type = YAHOO_P2P_WE_ARE_CLIENT; |
| 2972 p2p_data->source = -1; | 2972 p2p_data->source = -1; |
| 2973 | 2973 |
| 2974 /* connect to host */ | 2974 /* connect to host */ |
| 2975 if((purple_proxy_connect(NULL, account, host_ip, YAHOO_PAGER_PORT_P2P, yahoo_p2p_init_cb, p2p_data))==NULL) { | 2975 if((purple_proxy_connect(NULL, account, host_ip, YAHOO_PAGER_PORT_P2P, yahoo_p2p_init_cb, p2p_data))==NULL) { |
| 2976 yahoo_p2p_disconnect_destroy_data(p2p_data); | |
| 2977 purple_debug_info("yahoo","p2p: Connection to %s failed\n", host_ip); | 2976 purple_debug_info("yahoo","p2p: Connection to %s failed\n", host_ip); |
| 2977 g_free(p2p_data->host_ip); | |
| 2978 g_free(p2p_data->host_username); | |
| 2979 g_free(p2p_data); | |
| 2978 } | 2980 } |
| 2979 } | 2981 } |
| 2980 } | 2982 } |
| 2981 | 2983 |
| 2982 static void yahoo_process_audible(PurpleConnection *gc, struct yahoo_packet *pkt) | 2984 static void yahoo_process_audible(PurpleConnection *gc, struct yahoo_packet *pkt) |