Mercurial > pidgin
comparison plugins/notify.c @ 12184:5cd2294127e8
[gaim-migrate @ 14486]
SF Patch #1363103, Casey Harkins
'From the wiki:
"Crash when Message Notification plugin is set to use
the Urgent hint, when a message is queued by the new
queuing code."
XGetWMHints() is returning NULL on the hidden
conversation window which holds the "queued" conversations.
The man page says:
"The XGetWMHints function reads the window manager
hints and returns NULL if no WM_HINTS property was set
on the window or returns a pointer to a XWMHints
structure if it succeeds."
This patch allocates it if its NULL. This might not be
necessary, as setting the URGENT hint on an unmapped
window is not really going to do anything.
Probably too much explanation for a 2 line patch. :-)'
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Tue, 22 Nov 2005 00:18:28 +0000 |
| parents | 89e416ac9ef7 |
| children | 255e6912607b |
comparison
equal
deleted
inserted
replaced
| 12183:891aeb151590 | 12184:5cd2294127e8 |
|---|---|
| 513 g_return_if_fail(win->window != NULL); | 513 g_return_if_fail(win->window != NULL); |
| 514 g_return_if_fail(win->window->window != NULL); | 514 g_return_if_fail(win->window->window != NULL); |
| 515 | 515 |
| 516 hints = XGetWMHints(GDK_WINDOW_XDISPLAY(win->window->window), | 516 hints = XGetWMHints(GDK_WINDOW_XDISPLAY(win->window->window), |
| 517 GDK_WINDOW_XWINDOW(win->window->window)); | 517 GDK_WINDOW_XWINDOW(win->window->window)); |
| 518 if(!hints) | |
| 519 hints = XAllocWMHints(); | |
| 518 if (add) | 520 if (add) |
| 519 hints->flags |= XUrgencyHint; | 521 hints->flags |= XUrgencyHint; |
| 520 else | 522 else |
| 521 hints->flags &= ~XUrgencyHint; | 523 hints->flags &= ~XUrgencyHint; |
| 522 XSetWMHints(GDK_WINDOW_XDISPLAY(win->window->window), | 524 XSetWMHints(GDK_WINDOW_XDISPLAY(win->window->window), |