comparison libpurple/protocols/myspace/myspace.c @ 17305:6476a55a9542

msim_status_cb() now takes a MsimMessage *, just like msim_send_im_cb() and msim_incoming_im_cb(). This will ease the transition to a callbackless system.

17304:4a62ba3baa0c

/** 
 * Callback to update incoming status messages, after looked up username.
 *
 * @param session 
 * @param userinfo Looked up user information from server.
 * @param data gchar * status string, will be freed.
 *
 */
void msim_status_cb(MsimSession *session, MsimMessage *userinfo, gpointer data)
{
    PurpleBuddyList *blist;
    PurpleBuddy *buddy;
    GHashTable *body;
	gchar *body_str;
    //PurpleStatus *status;

    gchar *username;

    g_return_if_fail(MSIM_SESSION_VALID(session));
    g_return_if_fail(userinfo != NULL);

    status_str = (gchar *)data;

	body_str = msim_msg_get_string(userinfo, "body");
    body = msim_parse_body(body_str);
	g_free(body_str);
	g_return_if_fail(body != NULL);

				purple_status_code = PURPLE_STATUS_AVAILABLE;
	}
	purple_prpl_got_user_status(session->account, username, purple_primitive_get_id_from_type(purple_status_code), NULL);

    g_strfreev(status_array);
    g_list_free(list);
    g_hash_table_destroy(body);
    /* msim_msg_free(userinfo);  TODO: right? */
    /* Do not free status_str - it will currently be freed by g_hash_table_destroy 
	 * on session->user_lookup_cb_data. But this is questionable (TODO: unask) since
	 * sometimes user_lookup_cb_data stores integers in gpointers, and sometimes
	 * real gpointers that need to be freed, like our status_str. 
	 */
	/* g_free(status_str); */
}

/**
 * Process incoming status messages.
 *

 *
 * @return TRUE if successful.
 */
gboolean msim_status(MsimSession *session, MsimMessage *msg)
{
    gchar *status_str;
    gchar *userid;

    g_return_val_if_fail(MSIM_SESSION_VALID(session), FALSE);
    g_return_val_if_fail(msg != NULL, FALSE);

	/* TODO: free */
    status_str = msim_msg_get_string(msg, "msg");
	g_return_val_if_fail(status_str != NULL, FALSE);

	/* TODO: free */
    userid = msim_msg_get_string(msg, "f");
	g_return_val_if_fail(userid != NULL, FALSE);
   
    /* TODO: if buddies were identified on buddy list by uid, wouldn't have to lookup 
     * before updating the status! Much more efficient. */
    purple_debug_info("msim", 
			"msim_status: got status msg <%s> for <%s>, scheduling lookup\n",
            status_str, userid);
    
    /* Actually update status, once username is obtained. 
	 * status_str() will currently be freed by g_hash_table_destroy() on
	 * user_lookup_cb_data (TODO: this is questionable, since it can also
	 * store gpointers. Fix this, and the 2 other TODOs of the same problem.)
	 */
	/* TODO: don't use callbacks */
    msim_lookup_user(session, userid, msim_status_cb, status_str);

    return TRUE;
}

/** Add a buddy to user's buddy list. TODO: make work. Should receive statuses from added buddy. */

17305:6476a55a9542

/** 
 * Callback to update incoming status messages, after looked up username.
 *
 * @param session 
 * @param userinfo Looked up user information from server.
 * @param data MsimMessage * The status message.
 *
 */
void msim_status_cb(MsimSession *session, MsimMessage *userinfo, gpointer data)
{
	MsimMessage *msg;
    PurpleBuddyList *blist;
    PurpleBuddy *buddy;
    GHashTable *body;
	gchar *body_str;
    //PurpleStatus *status;

    gchar *username;

    g_return_if_fail(MSIM_SESSION_VALID(session));
    g_return_if_fail(userinfo != NULL);

	msg = (MsimMessage *)data;

    status_str = msim_msg_get_string(msg, "msg");

	body_str = msim_msg_get_string(userinfo, "body");
    body = msim_parse_body(body_str);
	g_free(body_str);
	g_return_if_fail(body != NULL);

				purple_status_code = PURPLE_STATUS_AVAILABLE;
	}
	purple_prpl_got_user_status(session->account, username, purple_primitive_get_id_from_type(purple_status_code), NULL);

    g_strfreev(status_array);
	g_free(status_str);
    g_list_free(list);
    g_hash_table_destroy(body);
	msim_msg_free(msg);
}

/**
 * Process incoming status messages.
 *

 *
 * @return TRUE if successful.
 */
gboolean msim_status(MsimSession *session, MsimMessage *msg)
{
    gchar *userid;

    g_return_val_if_fail(MSIM_SESSION_VALID(session), FALSE);
    g_return_val_if_fail(msg != NULL, FALSE);

	/* TODO: free? */
    userid = msim_msg_get_string(msg, "f");
	g_return_val_if_fail(userid != NULL, FALSE);
   
    /* TODO: if buddies were identified on buddy list by uid, wouldn't have to lookup 
     * before updating the status! Much more efficient. */
    purple_debug_info("msim", 
			"msim_status: got status for <%s>, scheduling lookup\n", userid);
    
    /* Actually update status, once username is obtained. 
	 * status_str() will currently be freed by g_hash_table_destroy() on
	 * user_lookup_cb_data (TODO: this is questionable, since it can also
	 * store gpointers. Fix this, and the 2 other TODOs of the same problem.)
	 */
	/* TODO: don't use callbacks */
	/* callback will free cloned msg */
    msim_lookup_user(session, userid, msim_status_cb, msim_msg_clone(msg));

    return TRUE;
}

/** Add a buddy to user's buddy list. TODO: make work. Should receive statuses from added buddy. */