comparison libpurple/dnsquery.c @ 24122:6dae9cefd3a1

Improve a few comments
author Mark Doliner <mark@kingant.net>
date Tue, 16 Sep 2008 23:29:22 +0000
parents 5395b18f9f08
children 14c5a8bbaa8d
comparison
equal deleted inserted replaced
24121:5395b18f9f08 24122:6dae9cefd3a1
83 */ 83 */
84 typedef struct { 84 typedef struct {
85 char hostname[512]; 85 char hostname[512];
86 int port; 86 int port;
87 } dns_params_t; 87 } dns_params_t;
88 #endif 88 #endif /* end PURPLE_DNSQUERY_USE_FORK */
89 89
90 static void 90 static void
91 purple_dnsquery_resolved(PurpleDnsQueryData *query_data, GSList *hosts) 91 purple_dnsquery_resolved(PurpleDnsQueryData *query_data, GSList *hosts)
92 { 92 {
93 purple_debug_info("dnsquery", "IP resolved for %s\n", query_data->hostname); 93 purple_debug_info("dnsquery", "IP resolved for %s\n", query_data->hostname);
417 return resolver; 417 return resolver;
418 } 418 }
419 419
420 /** 420 /**
421 * @return TRUE if the request was sent succesfully. FALSE 421 * @return TRUE if the request was sent succesfully. FALSE
422 * if the request could not be sent. This isn't 422 * if the request could not be sent. This isn't
423 * necessarily an error. If the child has expired, 423 * necessarily an error. If the child has expired,
424 * for example, we won't be able to send the message. 424 * for example, we won't be able to send the message.
425 */ 425 */
426 static gboolean 426 static gboolean
427 send_dns_request_to_child(PurpleDnsQueryData *query_data, 427 send_dns_request_to_child(PurpleDnsQueryData *query_data,
428 PurpleDnsQueryResolverProcess *resolver) 428 PurpleDnsQueryResolverProcess *resolver)
429 { 429 {
910 #if defined(PURPLE_DNSQUERY_USE_FORK) 910 #if defined(PURPLE_DNSQUERY_USE_FORK)
911 queued_requests = g_slist_remove(queued_requests, query_data); 911 queued_requests = g_slist_remove(queued_requests, query_data);
912 912
913 if (query_data->resolver != NULL) 913 if (query_data->resolver != NULL)
914 /* 914 /*
915 * Ideally we would tell our resolver child to stop resolving 915 * This is only non-NULL when we're cancelling an in-progress
916 * shit and then we would add it back to the free_dns_children 916 * query. Ideally we would tell our resolver child to stop
917 * linked list. However, it's hard to tell children stuff, 917 * resolving shit and then we would add it back to the
918 * they just don't listen. 918 * free_dns_children linked list. However, it's hard to tell
919 * children stuff, they just don't listen. So we'll just
920 * kill the process and allow a new child to be started if we
921 * have more stuff to resolve.
919 */ 922 */
920 purple_dnsquery_resolver_destroy(query_data->resolver); 923 purple_dnsquery_resolver_destroy(query_data->resolver);
921 #elif defined _WIN32 /* end PURPLE_DNSQUERY_USE_FORK */ 924 #elif defined _WIN32 /* end PURPLE_DNSQUERY_USE_FORK */
922 if (query_data->resolver != NULL) 925 if (query_data->resolver != NULL)
923 { 926 {
937 /* Free the address... */ 940 /* Free the address... */
938 g_free(query_data->hosts->data); 941 g_free(query_data->hosts->data);
939 query_data->hosts = g_slist_remove(query_data->hosts, query_data->hosts->data); 942 query_data->hosts = g_slist_remove(query_data->hosts, query_data->hosts->data);
940 } 943 }
941 g_free(query_data->error_message); 944 g_free(query_data->error_message);
942 #endif 945 #endif /* end _WIN32 */
943 946
944 if (query_data->timeout > 0) 947 if (query_data->timeout > 0)
945 purple_timeout_remove(query_data->timeout); 948 purple_timeout_remove(query_data->timeout);
946 949
947 g_free(query_data->hostname); 950 g_free(query_data->hostname);
991 while (free_dns_children != NULL) 994 while (free_dns_children != NULL)
992 { 995 {
993 purple_dnsquery_resolver_destroy(free_dns_children->data); 996 purple_dnsquery_resolver_destroy(free_dns_children->data);
994 free_dns_children = g_slist_remove(free_dns_children, free_dns_children->data); 997 free_dns_children = g_slist_remove(free_dns_children, free_dns_children->data);
995 } 998 }
996 #endif 999 #endif /* end PURPLE_DNSQUERY_USE_FORK */
997 } 1000 }