pidgin: src/gtkimhtml.c comparison

comparison src/gtkimhtml.c @ 11572:7be60d01519f

[gaim-migrate @ 13840] This should be more robust when dealing with different versions of iconv - we parse out the BOM and explicitly tell iconv what to do. This was lifted from the gtkhtml source. Ethan was concerned that some iconv implementations might be confused with the naming of the explicit charsets (UCS-2LE and UCS-2BE), so we should keep that in mind if people are having problems. This fixes the problem I was having that was caused by the BOM being removed by iconv during the UCS-2 to UTF-8 conversion. There is also some distracting whitespace fixing here to obscure any mistakes that I might have made. committer: Tailor Script <tailor@pidgin.im>

author	Daniel Atallah <daniel.atallah@gmail.com>
date	Tue, 27 Sep 2005 14:26:11 +0000
parents	b47708f46a38
children	03cd74ca2562

comparison

equal deleted inserted replaced

-:dd5a40c6699f
+:7be60d01519f
 				g_object_set(G_OBJECT(tag), "foreground", "light blue", NULL);
 		}
 	} else {
 		GTK_IMHTML(imhtml)->prelit_tag = NULL;
 	}
 	if ((oldprelit_tag != NULL) && (GTK_IMHTML(imhtml)->prelit_tag != oldprelit_tag)) {
 		gtk_widget_style_get(GTK_WIDGET(imhtml), "hyperlink-color", &norm, NULL);
 		if (norm)
 			g_object_set(G_OBJECT(oldprelit_tag), "foreground-gdk", norm, NULL);
 		else
 	gtk_text_view_window_to_buffer_coords(GTK_TEXT_VIEW(widget), GTK_TEXT_WINDOW_TEXT,
 	                                      event->area.x, event->area.y, &buf_x, &buf_y);
 	if (GTK_IMHTML(widget)->editable || GTK_IMHTML(widget)->wbfo) {
 		if (GTK_IMHTML(widget)->edit.background) {
 			gdk_color_parse(GTK_IMHTML(widget)->edit.background, &gcolor);
 			gdk_gc_set_rgb_fg_color(gc, &gcolor);
 		} else {
 			gdk_gc_set_rgb_fg_color(gc, &(widget->style->base[GTK_WIDGET_STATE(widget)]));
 		}
 		gdk_draw_rectangle(event->window,
 				   gc,
 				   TRUE,
 				   visible_rect.x, visible_rect.y, visible_rect.width, visible_rect.height);
 		gdk_gc_unref(gc);
 		if (GTK_WIDGET_CLASS (parent_class)->expose_event)
 			return (* GTK_WIDGET_CLASS (parent_class)->expose_event)
 				(widget, event);
 		return FALSE;
 	}
 	gtk_text_view_get_iter_at_location(GTK_TEXT_VIEW(widget), &start, buf_x, buf_y);
 	gtk_text_view_get_iter_at_location(GTK_TEXT_VIEW(widget), &end,
 	                                   buf_x + event->area.width, buf_y + event->area.height);
 		for (l = tags; l; l = l->next) {
 			GtkTextTag *tag = l->data;
 			GdkRectangle rect;
 			GdkRectangle tag_area;
 			const char *color;
 			if (strncmp(tag->name, "BACKGROUND ", 11))
 				continue;
 			if (gtk_text_iter_ends_tag(&cur, tag))
 				continue;
 			                                      &tag_area.y);
 			rect.width = visible_rect.width;
 			if (gtk_text_iter_is_end(&cur))
 				rect.height = visible_rect.y + visible_rect.height - rect.y;
 			else
 				rect.height = tag_area.y + tag_area.height - rect.y
 				              + gtk_text_view_get_pixels_below_lines(GTK_TEXT_VIEW(widget));
 			color = tag->name + 11;
 			if (!gdk_color_parse(color, &gcolor)) {
 				gchar tmp[8];
 				tmp[0] = '#';
 				if (!gdk_color_parse(tmp, &gcolor))
 					gdk_color_parse("white", &gcolor);
 			}
 			gdk_gc_set_rgb_fg_color(gc, &gcolor);
 			gdk_draw_rectangle(event->window,
 			                   gc,
 			                   TRUE,
 			                   rect.x, rect.y, rect.width, rect.height);
 			gtk_text_iter_backward_char(&cur); /* go back one, in case the end is the begining is the end
 		/* loop until another tag begins, or no tag begins */
 		while (gtk_text_iter_forward_to_tag_toggle(&cur, NULL) &&
 		       !gtk_text_iter_is_end(&cur) &&
 		       !gtk_text_iter_begins_tag(&cur, NULL));
 	}
 	gdk_gc_unref(gc);
 	if (GTK_WIDGET_CLASS (parent_class)->expose_event)
 		return (* GTK_WIDGET_CLASS (parent_class)->expose_event)
 			(widget, event);
 	gtk_menu_shell_insert(GTK_MENU_SHELL(menu), menuitem, 3);
 	g_signal_connect(G_OBJECT(menuitem), "activate",
 					 G_CALLBACK(paste_unformatted_cb), imhtml);
 }
+static char *
+ucs2_order(gboolean swap)
+{
+	gboolean be;
+	be = G_BYTE_ORDER == G_BIG_ENDIAN;
+	be = swap ? be : !be;
+	if (be)
+		return "UCS-2BE";
+	else
+		return "UCS-2LE";
+}
+/* Convert from UCS-2 to UTF-8, stripping the BOM if one is present.*/
+static gchar *
+ucs2_to_utf8_with_bom_check(guchar *data, guint len) {
+	char *fromcode = NULL;
+	GError *error = NULL;
+	guint16 c;
+	gchar *utf8_ret;
+	/*
+	 * Unicode Techinical Report 20
+	 * ( http://www.unicode.org/unicode/reports/tr20/ ) says to treat an
+	 * initial 0xfeff (ZWNBSP) as a byte order indicator so that is
+	 * what we do.  If there is no indicator assume it is in the default
+	 * order
+	 */
+	memcpy(&c, data, 2);
+	switch (c) {
+	case 0xfeff:
+	case 0xfffe:
+		fromcode = ucs2_order(c == 0xfeff);
+		data += 2;
+		len -= 2;
+		break;
+	default:
+		fromcode = "UCS-2";
+		break;
+	}
+	utf8_ret = g_convert(data, len, "UTF-8", fromcode, NULL, NULL, &error);
+	if (error) {
+		gaim_debug_warning("gtkimhtml", "g_convert error: %s\n", error->message);
+		g_error_free(error);
+	}
+	return utf8_ret;
+}
 static void gtk_imhtml_clipboard_get(GtkClipboard *clipboard, GtkSelectionData *selection_data, guint info, GtkIMHtml *imhtml) {
 	char *text;
 	gboolean primary;
 	GtkTextIter start, end;
 	}
 	if (selection_data->length >= 2 &&
 		(*(guint16 *)text == 0xfeff || *(guint16 *)text == 0xfffe)) {
 		/* This is UCS-2 */
-		char *tmp;
+		char *utf8 = ucs2_to_utf8_with_bom_check(text, selection_data->length);
-		char *utf8 = g_convert(text, selection_data->length, "UTF-8", "UCS-2", NULL, NULL, NULL);
 		g_free(text);
 		text = utf8;
 		if (!text) {
 			gaim_debug_warning("gtkimhtml", "g_convert from UCS-2 failed in paste_received_cb\n");
 			return;
 		}
-		tmp = g_utf8_next_char(text);
+	}
-		memmove(text, tmp, strlen(tmp) + 1);
-	}
 	if (!(*text) || !g_utf8_validate(text, -1, NULL)) {
 		gaim_debug_warning("gtkimhtml", "empty string or invalid UTF-8 in paste_received_cb\n");
 		g_free(text);
 		return;
 	}
 	imhtml->edit.backcolor = NULL;
 	imhtml->edit.fontface = NULL;
 	imhtml->edit.fontsize = 0;
 	imhtml->edit.link = NULL;
 	imhtml->scalables = NULL;
 	gtk_imhtml_set_editable(imhtml, FALSE);
 	g_signal_connect(G_OBJECT(imhtml), "populate-popup",
 					 G_CALLBACK(hijack_menu_cb), NULL);
 #ifdef _WIN32
 	/* Register HTML Format as desired clipboard format */
 	win_html_fmt = RegisterClipboardFormat("HTML Format");
 GdkDragContext   *context,
 gint              x,
 gint              y,
 guint             time)
 {
 	GdkDragAction suggested_action = 0;
 	if (gtk_drag_dest_find_target (widget, context, NULL) == GDK_NONE) {
 		/* can't accept any of the offered targets */
 	} else {
 		GtkWidget *source_widget;
 		suggested_action = context->suggested_action;
 		source_widget = gtk_drag_get_source_widget (context);
 		if (source_widget == widget) {
 			 * pressed ctrl or alt to affect available actions
 			 */
 			if ((context->actions & GDK_ACTION_MOVE) != 0)
 				suggested_action = GDK_ACTION_MOVE;
 		}
 	}
 	gdk_drag_status (context, suggested_action, time);
 /* TRUE return means don't propagate the drag motion to parent
 * widgets that may also be drop sites.
 */
 return TRUE;
 }
 static void
 gtk_imhtml_link_drop_cb(GtkWidget *widget, GdkDragContext *context, gint x, gint y, guint time, gpointer user_data)
 {
 	GdkAtom target = gtk_drag_dest_find_target (widget, context, NULL);
 	if (target != GDK_NONE)
 		gtk_drag_get_data (widget, context, target, time);
 	else
 		gtk_drag_finish (context, FALSE, FALSE, time);
 			 *
 			 * See also the comment on text/html here:
 			 * http://mail.gnome.org/archives/gtk-devel-list/2001-September/msg00114.html
 			 */
 			if (sd->length >= 2 && !g_utf8_validate(text, sd->length - 1, NULL)) {
-				utf8 = g_convert(text, sd->length, "UTF-8", "UCS-2", NULL, NULL, NULL);
+				utf8 = ucs2_to_utf8_with_bom_check(text, sd->length);
 				if (!utf8) {
 					gaim_debug_warning("gtkimhtml", "g_convert from UCS-2 failed in drag_rcv_cb\n");
 					return;
-				}
-				if (*(guint16 *)text == 0xfeff || *(guint16 *)text == 0xfffe || TRUE) {
-					char *tmp;
-					tmp = g_utf8_next_char(utf8);
-					memmove(utf8, tmp, strlen(tmp) + 1);
 				}
 			} else if (!(*text) || !g_utf8_validate(text, -1, NULL)) {
 				gaim_debug_warning("gtkimhtml", "empty string or invalid UTF-8 in drag_rcv_cb\n");
 				return;
 			}
 			if (!matched)
 				break;
 			pos = strchr (t->values->str, *amp);
 		}
 		else if (*x == '<') /* Because we're all WYSIWYG now, a '<'
 				     * char should only appear as the start of a tag.  Perhaps a safer (but costlier)
 				     * check would be to call gtk_imhtml_is_tag on it */
 			break;
 		else {
 			alen = 1;
 	GtkIMHtmlSmiley *smiley;
 	smiley = gtk_imhtml_smiley_get(imhtml,sml,text);
 	if (!smiley)
 		return NULL;
 	if (!smiley->icon && smiley->file) {
 		smiley->icon = gdk_pixbuf_animation_new_from_file(smiley->file, NULL);
 	} else if (!smiley->icon && smiley->loader) {
 		smiley->icon = gdk_pixbuf_loader_get_animation(smiley->loader);
 		if (smiley->icon)
 			g_object_ref(G_OBJECT(smiley->icon));
 	}
 	return smiley->icon;
 }
 #define VALID_TAG(x)	if (!g_ascii_strncasecmp (string, x ">", strlen (x ">"))) {	\
 				*tag = g_strndup (string, strlen (x));		\
 static const char *accepted_protocols[] = {
 	"http://",
 	"https://",
 	"ftp://"
 };
 static const int accepted_protocols_size = 3;
 /* returns if the beginning of the text is a protocol. If it is the protocol, returns the length so
 the caller knows how long the protocol string is. */
 int gtk_imhtml_is_protocol(const char *text)
 <KingAnt> marv: The two IM image functions in oscar are gaim_odc_send_im and gaim_odc_incoming
 [19:58] <Robot101> marv: images go into the imgstore, a refcounted... well.. hash. :)
 [19:59] <KingAnt> marv: I think the image tag used by the core is something like <img id="#"/>
 [19:59] Ro0tSiEgE robert42 RobFlynn Robot101 ross22 roz
 [20:00] <KingAnt> marv: Where the ID is the what is returned when you add the image to the imgstore using gaim_imgstore_add
 [20:00] <marv> Robot101: so how does the image get passed to serv_got_im() and serv_send_im()? just as the <img id="#" and then the prpl looks it up from the store?
 [20:00] <KingAnt> marv: Right
 [20:00] <marv> alright
 						}
 						else if (oldfont && oldfont->face)
 							font->face = g_strdup(oldfont->face);
 						if (font->face && (atoi(font->face) > 100)) {
 							/* WTF is this? */
 							/* Maybe it sets a max size on the font face?  I seem to
 							 * remember bad things happening if the font size was
 							 * 2 billion */
 							g_free(font->face);
 							font->face = g_strdup("100");
 						}
 	for (sl = tags; sl; sl = sl->next) {
 		tag = sl->data;
 		if (!gtk_text_iter_toggles_tag(start, GTK_TEXT_TAG(tag))) {
 			if (strlen(tag_to_html_end(tag)) > 0)
-		 		g_string_append(str, tag_to_html_start(tag));
+				g_string_append(str, tag_to_html_start(tag));
 			g_queue_push_tail(q, tag);
 		}
 	}
 	g_slist_free(tags);
 		for (sl = tags; sl; sl = sl->next) {
 			tag = sl->data;
 			if (gtk_text_iter_begins_tag(&iter, GTK_TEXT_TAG(tag))) {
 				if (strlen(tag_to_html_end(tag)) > 0)
-		 			g_string_append(str, tag_to_html_start(tag));
+					g_string_append(str, tag_to_html_start(tag));
 				g_queue_push_tail(q, tag);
 			}
 		}
 			if (anchor) {
 				char *text = g_object_get_data(G_OBJECT(anchor), "gtkimhtml_htmltext");
 				if (text)
 					str = g_string_append(str, text);
 			}
-		} else 	if (c == '<') {
+		} else if (c == '<') {
 			str = g_string_append(str, "&lt;");
 		} else if (c == '>') {
 			str = g_string_append(str, "&gt;");
 		} else if (c == '&') {
 			str = g_string_append(str, "&amp;");
 					if (tmp == NULL)
 						break;
 					if (!tag_ends_here(tmp, &iter, &nextiter) && strlen(tag_to_html_end(tmp)) > 0)
 						g_queue_push_tail(r, tmp);
-		 			g_string_append(str, tag_to_html_end(GTK_TEXT_TAG(tmp)));
+					g_string_append(str, tag_to_html_end(GTK_TEXT_TAG(tmp)));
 				}
 				if (tmp == NULL)
 					gaim_debug_warning("gtkimhtml", "empty queue, more closing tags than open tags!\n");
-		 		else
+				else
 					g_string_append(str, tag_to_html_end(GTK_TEXT_TAG(tag)));
 				while ((tmp = g_queue_pop_head(r))) {
 					g_string_append(str, tag_to_html_start(GTK_TEXT_TAG(tmp)));
 					g_queue_push_tail(q, tmp);

Mercurial > pidgin

comparison src/gtkimhtml.c @ 11572:7be60d01519f