Mercurial > pidgin

comparison src/protocols/msn/msn.c @ 6657:7e2d2c8e88a8

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[gaim-migrate @ 7182] Nathan Poznick writes: "I was checking over the translation changes that Bjoern submitted +for my Yahoo/MSN get user info patch, and I found that several strings +were improperly marked to be translated. For instance, consider the line: info_extract_field(stripped, url_text, "My Email", 5, "\n", 0, _("Private"), _("Email"), 0, NULL); In this case, "Private" should not be translated, since that function argument is used in the parsing, not in the displaying. There were instances of this in yahoo.c, and 6 instances in msn.c. The attached patches simply remove the _() from around those strings. I know 0.68 is supposed to be released tomorrow, so I hope these small changes can make it in - otherwise, it will mean that fetching an english profile will not work as designed, if gaim is running under a different locale." (11:20:50) faceprint: anyone look at the too-many-translated-strings thing on gaim-devel? (11:21:12) LSchiere: that's what i was just about to ask about (11:21:48) faceprint: looks kosher to me (11:21:51) LSchiere: yeah (11:23:30) SeanEgan: agreed committer: Tailor Script <tailor@pidgin.im>
author Luke Schierer <lschiere@pidgin.im>
date Sun, 31 Aug 2003 15:35:32 +0000
parents 156e6643f9db
children 0c5637b5462e
comparison
equal deleted inserted replaced
6656:dd9e0bd6488e 6657:7e2d2c8e88a8
1209 /* gonna re-use the memory we've already got for url_text */ 1209 /* gonna re-use the memory we've already got for url_text */
1210 strcpy(url_text, "<html><body>\n"); 1210 strcpy(url_text, "<html><body>\n");
1211 1211
1212 /* extract their Name and put it in */ 1212 /* extract their Name and put it in */
1213 info_extract_field(stripped, url_text, "\tName", 0, "\t", '\n', 1213 info_extract_field(stripped, url_text, "\tName", 0, "\t", '\n',
1214 _("Undisclosed"), _("Name"), 0, NULL); 1214 "Undisclosed", _("Name"), 0, NULL);
1215 1215
1216 /* extract their Age and put it in */ 1216 /* extract their Age and put it in */
1217 info_extract_field(stripped, url_text, "\tAge", 0, "\t", '\n', 1217 info_extract_field(stripped, url_text, "\tAge", 0, "\t", '\n',
1218 _("Undisclosed"), _("Age"), 0, NULL); 1218 "Undisclosed", _("Age"), 0, NULL);
1219 1219
1220 /* extract their Gender and put it in */ 1220 /* extract their Gender and put it in */
1221 info_extract_field(stripped, url_text, "\tGender", 6, "\t", '\n', 1221 info_extract_field(stripped, url_text, "\tGender", 6, "\t", '\n',
1222 _("Undisclosed"), _("Gender"), 0, NULL); 1222 "Undisclosed", _("Gender"), 0, NULL);
1223 1223
1224 /* extract their MaritalStatus and put it in */ 1224 /* extract their MaritalStatus and put it in */
1225 info_extract_field(stripped, url_text, "\tMaritalStatus", 0, "\t", '\n', 1225 info_extract_field(stripped, url_text, "\tMaritalStatus", 0, "\t", '\n',
1226 _("Undisclosed"), _("Marital Status"), 0, NULL); 1226 "Undisclosed", _("Marital Status"), 0, NULL);
1227 1227
1228 /* extract their Location and put it in */ 1228 /* extract their Location and put it in */
1229 info_extract_field(stripped, url_text, "\tLocation", 0, "\t", '\n', 1229 info_extract_field(stripped, url_text, "\tLocation", 0, "\t", '\n',
1230 _("Undisclosed"), _("Location"), 0, NULL); 1230 "Undisclosed", _("Location"), 0, NULL);
1231 1231
1232 /* extract their Occupation and put it in */ 1232 /* extract their Occupation and put it in */
1233 info_extract_field(stripped, url_text, "\t Occupation", 6, "\t", '\n', 1233 info_extract_field(stripped, url_text, "\t Occupation", 6, "\t", '\n',
1234 _("Undisclosed"), _("Occupation"), 0, NULL); 1234 "Undisclosed", _("Occupation"), 0, NULL);
1235 1235
1236 /* the fields, 'A Little About Me', 'Favorite Things', 'Hobbies and Interests', 1236 /* the fields, 'A Little About Me', 'Favorite Things', 'Hobbies and Interests',
1237 * 'Favorite Quote', and 'My Homepage' may or may not appear, in any combination. 1237 * 'Favorite Quote', and 'My Homepage' may or may not appear, in any combination.
1238 * however, they do appear in certain order, so we can successively search to 1238 * however, they do appear in certain order, so we can successively search to
1239 * pin down the distinct values. 1239 * pin down the distinct values.