comparison libpurple/protocols/myspace/message.c @ 19254:9245404fe70c

In msim_msg_get(), start at the given node instead of using g_list_first() to back track and find the first node (since GList's are doubly-linked, it can do this). This means that msim_msg_get_*() functions now return values beginning from the MsimMessage * that was passed to the function, instead of at the very beginning, so you can pass an MsimMessage pointer in the middle of an MsimMessage (which is really just a GList) and it will search starting from where you gave it.

19253:b66c5991c011

 *
 */
static GList *
msim_msg_get_node(MsimMessage *msg, const gchar *name)
{
	GList *i;

	if (!name) {
		return NULL;
	}

	/* Linear search for the given name. O(n) but n is small. */
	for (i = g_list_first(msg); i != NULL; i = g_list_next(i)) {
		MsimMessageElement *elem;

		elem = i->data;
		g_return_val_if_fail(elem != NULL, NULL);

		if (strcmp(elem->name, name) == 0) {
			return i;
		}
	}
	return NULL;
}

19254:9245404fe70c

 *
 */
static GList *
msim_msg_get_node(MsimMessage *msg, const gchar *name)
{
	GList *node;

	if (!name) {
		return NULL;
	}

	/* Linear search for the given name. O(n) but n is small. */
	for (node = msg; node != NULL; node = g_list_next(node)) {
		MsimMessageElement *elem;

		elem = node->data;
		g_return_val_if_fail(elem != NULL, NULL);

		if (strcmp(elem->name, name) == 0) {
			return node;
		}
	}
	return NULL;
}