comparison libpurple/protocols/yahoo/yahoo.c @ 24400:9e0458c98b4c

This was originally a patch from Brian Geppert that corrected the 'silently truncates messages at 800 characters' bug in yahoo. I changed the patch to reflect the reality I saw, which is that the maximum message length is 946 bytes, but only 800 characters. It's possible to fall between 800 and 946 bytes but not exceed 800 characters by using multibyte characters.

24399:9bdaf273c0ff

	char *msg2;
	gboolean utf8 = TRUE;
	PurpleWhiteboard *wb;
	int ret = 1;
	YahooFriend *f = NULL;

	msg2 = yahoo_string_encode(gc, msg, &utf8);

	yahoo_packet_hash(pkt, "ss", 1, purple_connection_get_display_name(gc), 5, who);
	if ((f = yahoo_friend_find(gc, who)) && f->protocol)
		yahoo_packet_hash_int(pkt, 241, f->protocol);

24400:9e0458c98b4c

	char *msg2;
	gboolean utf8 = TRUE;
	PurpleWhiteboard *wb;
	int ret = 1;
	YahooFriend *f = NULL;
	gsize lenb = 0;
	glong lenc = 0;

	msg2 = yahoo_string_encode(gc, msg, &utf8);
	
	if(msg2) {
		lenb = strlen(msg2);
		lenc = g_utf8_strlen(msg2, -1);

		if(lenb > YAHOO_MAX_MESSAGE_LENGTH_BYTES || lenc > YAHOO_MAX_MESSAGE_LENGTH_CHARS) {
			purple_debug_info("yahoo", "Message too big.  Length is %" G_GSIZE_FORMAT
					" bytes, %ld characters.  Max is %d bytes, %d chars."
					"  Message is '%s'.\n", lenb, lenc, YAHOO_MAX_MESSAGE_LENGTH_BYTES,
					YAHOO_MAX_MESSAGE_LENGTH_CHARS, msg2);
			yahoo_packet_free(pkt);
			g_free(msg);
			g_free(msg2);
			return -E2BIG;
		}
	}

	yahoo_packet_hash(pkt, "ss", 1, purple_connection_get_display_name(gc), 5, who);
	if ((f = yahoo_friend_find(gc, who)) && f->protocol)
		yahoo_packet_hash_int(pkt, 241, f->protocol);