comparison HACKING @ 2144:a9940cdb86ee

[gaim-migrate @ 2154] coding style. mmm. Also got rid of po/ChangeLog, it's autogenerated and we don't use it. committer: Tailor Script <tailor@pidgin.im>
author Eric Warmenhoven <eric@warmenhoven.org>
date Wed, 15 Aug 2001 18:09:48 +0000
parents bf2434d36e54
children eb2cadb18479
comparison
equal deleted inserted replaced
2143:e257c17864eb 2144:a9940cdb86ee
31 (don't bother with two trees, or even two copies of the same file). Then 31 (don't bother with two trees, or even two copies of the same file). Then
32 when you're ready to make your patch, simply run 'cvs diff -u >my.patch' 32 when you're ready to make your patch, simply run 'cvs diff -u >my.patch'
33 and send it off. 33 and send it off.
34 34
35 This file was last modified by $Author: warmenhoven $ on 35 This file was last modified by $Author: warmenhoven $ on
36 $Date: 2001-05-19 20:01:55 -0400 (Sat, 19 May 2001) $. 36 $Date: 2001-08-15 14:09:48 -0400 (Wed, 15 Aug 2001) $.
37
38
39 CODING STYLE
40 ============
41
42 Coding styles are like assholes, everyone has one and no one likes
43 anyone elses. This is mine and if you want me to accept a patch from
44 you without getting annoyed you'll follow this coding style. :)
45
46 It would probably just be easier for me to include CodingStyle from the
47 linux kernel source.
48
49 Tab indents. I *HATE* 2-space indents, and I strongly dislike 8-space
50 indents. Use a tab character. I'm likely to refuse a patch if it has
51 2-space indents.
52
53 K&R style for braces. Braces always go on the same line as the if, etc.
54 that they're associated with; the only exception is functions. Braces
55 for else statements should have both braces on the same line as the else
56 (i.e. "} else {").
57
58 No functionOrVariableNamesLikeThis. Save it for Java. Underscores are
59 your friend. "tmp" is an excellent variable name. Hungarian style will
60 not be tolerated. Go back to Microsoft.
61
62 I have a 105-char wide Eterm. Deal with it.
63
64 NO goto. I'm very likely to refuse a patch if it makes use of goto. If
65 you feel the need to use goto, you need to rethink your design and flow.
37 66
38 67
39 PROGRAM FLOW 68 PROGRAM FLOW
40 ============ 69 ============
41 70