pidgin: src/plugin.c comparison

comparison src/plugin.c @ 6981:abd3c684da31

[gaim-migrate @ 7537] Fixes some issues with plugin loading. Previously, all protocol plugins were loaded as soon as they were probed, but this caused issues if they had a dependency on another plugin. Now, they're all stuffed in a queue, which is processed after probing, so that all plugins are found. Also, a plugin's load function can return FALSE to prevent itself from being loaded. I thought I did that already... committer: Tailor Script <tailor@pidgin.im>

author	Christian Hammond <chipx86@chipx86.com>
date	Sat, 27 Sep 2003 15:45:49 +0000
parents	7dba3e17cb21
children	083d1e4a9c78

comparison

equal deleted inserted replaced

-:1da447732906
+:abd3c684da31
 	GaimValue **params;
 	GaimValue *ret_value;
 } GaimPluginIpcCommand;
-static GList *loaded_plugins = NULL;
+static GList *loaded_plugins   = NULL;
-static GList *plugins = NULL;
+static GList *plugins          = NULL;
-static GList *plugin_loaders = NULL;
+static GList *plugin_loaders   = NULL;
 static GList *protocol_plugins = NULL;
+static GList *load_queue       = NULL;
 static size_t search_path_count = 0;
 static char **search_paths = NULL;
 static void (*probe_cb)(void *) = NULL;
 #ifdef GAIM_PLUGINS
 	GaimPlugin *plugin = NULL;
 	GaimPlugin *loader;
 	gboolean (*gaim_init_plugin)(GaimPlugin *);
+	gaim_debug_misc("plugins", "probing %s\n", filename);
 	g_return_val_if_fail(filename != NULL, NULL);
 	if (!g_file_test(filename, G_FILE_TEST_EXISTS))
 		return NULL;
 	}
 	if (dep_list != NULL)
 		g_list_free(dep_list);
-	if (plugin->native_plugin) {
+	if (plugin->native_plugin)
-		if (plugin->info != NULL) {
+	{
-			if (plugin->info->load != NULL)
+		if (plugin->info != NULL && plugin->info->load != NULL)
-				plugin->info->load(plugin);
+		{
+			if (!plugin->info->load(plugin))
+				return FALSE;
 		}
 	}
 	else {
 		GaimPlugin *loader;
 		GaimPluginLoaderInfo *loader_info;
 			return FALSE;
 		loader_info = GAIM_PLUGIN_LOADER_INFO(loader);
 		if (loader_info->load != NULL)
-			loader_info->load(plugin);
+		{
+			if (!loader_info->load(plugin))
+				return FALSE;
+		}
 	}
 	loaded_plugins = g_list_append(loaded_plugins, plugin);
 	plugin->loaded = TRUE;
 	if (gaim_plugin_is_loaded(plugin))
 		gaim_plugin_unload(plugin);
 	plugins = g_list_remove(plugins, plugin);
+	if (load_queue != NULL)
+		load_queue = g_list_remove(load_queue, plugin);
 	if (plugin->info != NULL && plugin->info->dependencies != NULL)
 		g_list_free(plugin->info->dependencies);
 	if (plugin->native_plugin) {
 void
 gaim_plugins_probe(const char *ext)
 {
 #ifdef GAIM_PLUGINS
+	GList *l, *l_next;
 	GDir *dir;
 	const gchar *file;
 	gchar *path;
 	GaimPlugin *plugin;
 	size_t i;
 			g_dir_close(dir);
 		}
 	}
+	/* See if we have any plugins waiting to load. */
+	while (load_queue != NULL)
+	{
+		plugin = (GaimPlugin *)load_queue->data;
+		load_queue = g_list_remove(load_queue, plugin);
+		if (plugin == NULL || plugin->info == NULL)
+			continue;
+		if (plugin->info->type == GAIM_PLUGIN_LOADER)
+		{
+			GList *exts;
+			/* We'll just load this right now. */
+			if (!gaim_plugin_load(plugin))
+			{
+				gaim_plugin_destroy(plugin);
+				continue;
+			}
+			plugin_loaders = g_list_append(plugin_loaders, plugin);
+			for (exts = GAIM_PLUGIN_LOADER_INFO(plugin)->exts;
+				 exts != NULL;
+				 exts = exts->next)
+			{
+				gaim_plugins_probe(exts->data);
+			}
+		}
+		else if (plugin->info->type == GAIM_PLUGIN_PROTOCOL)
+		{
+			/* We'll just load this right now. */
+			if (!gaim_plugin_load(plugin))
+			{
+				gaim_plugin_destroy(plugin);
+				continue;
+			}
+			if (GAIM_PLUGIN_PROTOCOL_INFO(plugin)->protocol == GAIM_PROTO_ICQ ||
+				gaim_find_prpl(GAIM_PLUGIN_PROTOCOL_INFO(plugin)->protocol))
+			{
+				/* Nothing to see here--move along, move along */
+				gaim_plugin_destroy(plugin);
+				continue;
+			}
+			protocol_plugins = g_list_insert_sorted(protocol_plugins, plugin,
+													(GCompareFunc)compare_prpl);
+		}
+	}
+	if (load_queue != NULL)
+	{
+		g_list_free(load_queue);
+		load_queue = NULL;
+	}
 	if (probe_cb != NULL)
 		probe_cb(probe_cb_data);
 #endif /* GAIM_PLUGINS */
 }
 	g_return_val_if_fail(plugin != NULL, FALSE);
 	if (g_list_find(plugins, plugin))
 		return TRUE;
-	/* Special exception for loader plugins. We want them loaded NOW! */
+	if (plugin->info->type == GAIM_PLUGIN_LOADER ||
-	if (plugin->info->type == GAIM_PLUGIN_LOADER) {
+		plugin->info->type == GAIM_PLUGIN_PROTOCOL)
-		GList *exts;
+	{
+		/* Special exception for loader plugins. We want them loaded NOW! */
-		/* We'll just load this right now. */
+		load_queue = g_list_append(load_queue, plugin);
-		if (!gaim_plugin_load(plugin)) {
-			gaim_plugin_destroy(plugin);
-			return FALSE;
-		}
-		plugin_loaders = g_list_append(plugin_loaders, plugin);
-		for (exts = GAIM_PLUGIN_LOADER_INFO(plugin)->exts;
-			 exts != NULL;
-			 exts = exts->next) {
-			gaim_plugins_probe(exts->data);
-		}
-	}
-	else if (plugin->info->type == GAIM_PLUGIN_PROTOCOL) {
-		/* We'll just load this right now. */
-		if (!gaim_plugin_load(plugin)) {
-			gaim_plugin_destroy(plugin);
-			return FALSE;
-		}
-		if (GAIM_PLUGIN_PROTOCOL_INFO(plugin)->protocol == GAIM_PROTO_ICQ ||
-			gaim_find_prpl(GAIM_PLUGIN_PROTOCOL_INFO(plugin)->protocol)) {
-			/* Nothing to see here--move along, move along */
-			gaim_plugin_destroy(plugin);
-			return FALSE;
-		}
-		protocol_plugins = g_list_insert_sorted(protocol_plugins, plugin,
-												(GCompareFunc)compare_prpl);
 	}
 	plugins = g_list_append(plugins, plugin);
 	return TRUE;

Mercurial > pidgin

comparison src/plugin.c @ 6981:abd3c684da31