Mercurial > pidgin
comparison COPYRIGHT @ 10039:cf02e7104706
[gaim-migrate @ 10998]
A patch from rian hunter (chrono86):
In src/protocols/oscar/oscar.c, in the function
gaim_plugin_oscar_convert_to_best_encoding. g_convert
is called multiple times. As its 5th argument g_convert
takes a gsize* (8 byte), yet the argument to
gaim_plugin_oscar_convert_to_best_encoding is a int* (4
byte).
On LP64 machines this can allow the int* to be
overwritten. This is especially bad on big endian
64-bit machines, causing the high 32-bits to be written
into the low 32-bits of the int.
This is a quick fix patch that lets g_convert deal with
a gsize* pointer instead, then casting the value at
gsize* to the value at the int*.
A real fix would be to fix the aim_sendimext_args
structure to have a gsize instead of an int (and all
functions that use the aim_sendimext_args struct), and
changing gaim_plugin_oscar_convert_to_best_encoding to
accept a gsize*. of course, this woudl promote glib2
dependence, so that's probably not the best thing to do.
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Sat, 18 Sep 2004 23:17:18 +0000 |
| parents | 1ececa0e7072 |
| children | e2890a4585c0 |
comparison
equal
deleted
inserted
replaced
| 10038:eb8ccdd6f5f2 | 10039:cf02e7104706 |
|---|---|
| 71 G. Sumner Hayes | 71 G. Sumner Hayes |
| 72 Mike Heffner | 72 Mike Heffner |
| 73 Casey Ho | 73 Casey Ho |
| 74 Iain Holmes | 74 Iain Holmes |
| 75 Karsten Huneycutt | 75 Karsten Huneycutt |
| 76 Rian Hunter | |
| 76 Henry Jen | 77 Henry Jen |
| 77 Akuke Kok | 78 Akuke Kok |
| 78 Cole Kowalski | 79 Cole Kowalski |
| 79 Gary Kramlich | 80 Gary Kramlich |
| 80 Tero Kuusela | 81 Tero Kuusela |