comparison src/protocols/oscar/service.c @ 5892:da8939ad60b6

[gaim-migrate @ 6324] Fixes a spelling mistake. Fixes a rare possible-crash in oscar. Shuffled some code around. I tend to do this a lot. Attemped to fix the buddy icon infi-loop thing. Sean, search for "81" in oscar.c I commented that out. I'm pretty sure it will stop the looping, but do you know why that's there? I don't really understand when the server would send 0x81 as "flags," or what it means. Good night, moon. committer: Tailor Script <[e-mail]>

5891:58ea0597a856

}

/*
 * Subtype 0x0021 - Receive our extended status
 *
 * This is used for MAC non-away "away" messages, and maybe ICQ extended status messages?
 * It's also used to tell the client whether or not it needs to upload an SSI buddy icon... who engineers this stuff, anyway?
 */
static int aim_parse_extstatus(aim_session_t *sess, aim_module_t *mod, aim_frame_t *rx, aim_modsnac_t *snac, aim_bstream_t *bs)
{
	int ret = 0, i;
	aim_rxcallback_t userfunc;
	char *msg = NULL, *md5 = NULL;
	fu16_t type;
	fu8_t number, length, cached;

	type = aimbs_get16(bs); 
	if ((userfunc = aim_callhandler(sess, rx->conn, snac->family, snac->subtype))) {
		switch (type) {
		case 0x0001:
		case 0x0000: /* not sure what the difference between 1 and 0 is */
			cached = aimbs_get8(bs);
			length = aimbs_get8(bs);
			md5 = aimbs_getraw(bs, length);
			ret = userfunc(sess, rx, type, cached, length, md5);
			free(md5);
			break;
		case 0x0002:
			number = aimbs_get8(bs); /* 0x04 */
			length = aimbs_get8(bs); /* the first length */
			msg = aimbs_getstr(bs, aimbs_get16(bs)); /* the second length is just for the message */
			ret = userfunc(sess, rx, msg);
			free(msg);
			break;
		}
	}
		return ret;
}

5892:da8939ad60b6

}

/*
 * Subtype 0x0021 - Receive our extended status
 *
 * This is used for iChat's "available" messages, and maybe ICQ extended 
 * status messages?  It's also used to tell the client whether or not it 
 * needs to upload an SSI buddy icon... who engineers this stuff, anyway?
 */
static int aim_parse_extstatus(aim_session_t *sess, aim_module_t *mod, aim_frame_t *rx, aim_modsnac_t *snac, aim_bstream_t *bs)
{
	int ret = 0;
	aim_rxcallback_t userfunc;
	fu16_t type;
	fu8_t flags, length;

	type = aimbs_get16(bs); 
	flags = aimbs_get8(bs);
	length = aimbs_get8(bs);

	if ((userfunc = aim_callhandler(sess, rx->conn, snac->family, snac->subtype))) {
		switch (type) {
		case 0x0000:
		case 0x0001: { /* not sure what the difference between 1 and 0 is */
			fu8_t *md5 = aimbs_getraw(bs, length);
			ret = userfunc(sess, rx, type, flags, length, md5);
			free(md5);
			} break;
		case 0x0002: {
			/* there is a second length that is just for the message */
			char *msg = aimbs_getstr(bs, aimbs_get16(bs));
			ret = userfunc(sess, rx, msg);
			free(msg);
			} break;
		}
	}
		return ret;
}