Mercurial > pidgin
comparison libpurple/plugins/perl/common/PluginPref.xs @ 25262:df6d3c3574ce
Make Purple::PluginPref->get_bounds be more perl-like.
It no longer expects to be called as:
$ppref->get_bounds($min, $max)
or
$ppref->get_bounds(\$min, \$max)
(I'm not even sure which one of those was intended to be correct, but
apparently they both crash.)
It now expects to be called like this:
my ($min, $max) = $ppref->get_bounds();
author | Etan Reisner <pidgin@unreliablesource.net> |
---|---|
date | Tue, 06 Jan 2009 05:36:39 +0000 |
parents | b0812ce0ec17 |
children |
comparison
equal
deleted
inserted
replaced
24917:61f3a9f7a220 | 25262:df6d3c3574ce |
---|---|
68 purple_plugin_pref_destroy(pref) | 68 purple_plugin_pref_destroy(pref) |
69 Purple::PluginPref pref | 69 Purple::PluginPref pref |
70 | 70 |
71 | 71 |
72 void | 72 void |
73 purple_plugin_pref_get_bounds(pref, min, max) | 73 purple_plugin_pref_get_bounds(pref, OUTLIST int min, OUTLIST int max) |
74 Purple::PluginPref pref | 74 Purple::PluginPref pref |
75 int *min | 75 # According to the perlxs manual page we shouldn't need to specify a |
76 int *max | 76 # prototype here because "[p]arameters preceded by OUTLIST keyword do |
77 # not appear in the usage signature of the generated Perl function." | |
78 # however that appears to only work for the usage error message and | |
79 # not for the call to newXSproto. Since I can't find any documentation | |
80 # for newXSproto at the moment I have no idea if that matters so | |
81 # override the prototype here. | |
82 PROTOTYPE: $ | |
77 | 83 |
78 void | 84 void |
79 purple_plugin_pref_get_choices(pref) | 85 purple_plugin_pref_get_choices(pref) |
80 Purple::PluginPref pref | 86 Purple::PluginPref pref |
81 PREINIT: | 87 PREINIT: |