Mercurial > pidgin

comparison libpurple/util.c @ 26894:e4ab3d5362df

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Only log requested HTTP URL's when PURPLE_UNSAFE_DEBUG is set and change MSN to use PURPLE_UNSAFE_DEBUG instead of PURPLE_MSN_UNSAFE_DEBUG for consistency. Not logging URL's will prevent potential password disclosure for the Yahoo HTTP login method.
author John Bailey <rekkanoryo@rekkanoryo.org>
date Thu, 14 May 2009 02:12:40 +0000
parents ab31daf1c1ee
children 6ddb4932772a
comparison
equal deleted inserted replaced
26893:37436c98201e 26894:e4ab3d5362df
3918 (gfud->http11 ? "1.1" : "1.0"), 3918 (gfud->http11 ? "1.1" : "1.0"),
3919 (gfud->website.address ? gfud->website.address : "")); 3919 (gfud->website.address ? gfud->website.address : ""));
3920 } 3920 }
3921 } 3921 }
3922 3922
3923 purple_debug_misc("util", "Request: '%s'\n", gfud->request); 3923 if(g_getenv("PURPLE_UNSAFE_DEBUG"))
3924 purple_debug_misc("util", "Request: '%s'\n", gfud->request);
3925 else
3926 purple_debug_misc("util", "request constructed\n");
3924 3927
3925 total_len = strlen(gfud->request); 3928 total_len = strlen(gfud->request);
3926 3929
3927 if (gfud->is_ssl) 3930 if (gfud->is_ssl)
3928 len = purple_ssl_write(gfud->ssl_connection, gfud->request + gfud->request_written, 3931 len = purple_ssl_write(gfud->ssl_connection, gfud->request + gfud->request_written,
4021 PurpleUtilFetchUrlData *gfud; 4024 PurpleUtilFetchUrlData *gfud;
4022 4025
4023 g_return_val_if_fail(url != NULL, NULL); 4026 g_return_val_if_fail(url != NULL, NULL);
4024 g_return_val_if_fail(callback != NULL, NULL); 4027 g_return_val_if_fail(callback != NULL, NULL);
4025 4028
4026 purple_debug_info("util", 4029 if(g_getenv("PURPLE_UNSAFE_DEBUG"))
4027 "requested to fetch (%s), full=%d, user_agent=(%s), http11=%d\n", 4030 purple_debug_info("util",
4028 url, full, user_agent?user_agent:"(null)", http11); 4031 "requested to fetch (%s), full=%d, user_agent=(%s), http11=%d\n",
4032 url, full, user_agent?user_agent:"(null)", http11);
4033 else
4034 purple_debug_info("util", "requesting to fetch a URL\n");
4029 4035
4030 gfud = g_new0(PurpleUtilFetchUrlData, 1); 4036 gfud = g_new0(PurpleUtilFetchUrlData, 1);
4031 4037
4032 gfud->callback = callback; 4038 gfud->callback = callback;
4033 gfud->user_data = user_data; 4039 gfud->user_data = user_data;