comparison libpurple/core.c @ 18148:f160b6e84d0c

Use dynamicly allocated string manipulation here as well to avoid a MAXPATHLEN. This is untested, as I don't use Zephyr. This also leaks a string at libpurple uninit. If that's bad, I can add a callback to this file and call it from the prpl's unload callback. References #1635

18147:5653692dcf79

		if (g_file_test(name, G_FILE_TEST_IS_SYMLINK))
		{
			/* We're only going to duplicate a logs symlink. */
			if (!strcmp(entry, "logs"))
			{
				char buf[MAXPATHLEN];
				size_t linklen;

				if ((linklen = readlink(name, buf, sizeof(buf) - 1) == -1))
				{
					purple_debug_error("core", "Error reading symlink %s: %s. Please report this at http://developer.pidgin.im\n",
					                   name, strerror(errno));
					g_free(name);
					g_dir_close(dir);
					g_free(status_file);
					g_free(old_user_dir);
					return FALSE;
				}
				buf[linklen] = '\0';

				logs_dir = g_strconcat(user_dir, G_DIR_SEPARATOR_S "logs", NULL);

				if (!strcmp(buf, "../.purple/logs") || !strcmp(buf, logs_dir))
				{
					/* If the symlink points to the new directory, we're
					 * likely just trying again after a failed migration,
					 * so there's no need to fail here. */
					g_free(logs_dir);
					continue;
				}

				/* In case we are trying again after a failed migration, we need

				 * will fail, and so will the symlink below, which is good
				 * because the user should sort things out. */
				g_unlink(logs_dir);

				/* Relative links will most likely still be
				 * valid from ~/.purple, though not it's not
				 * guaranteed.  Oh well. */
				if (symlink(buf, logs_dir))
				{
					purple_debug_error("core", "Error symlinking %s to %s: %s. Please report this at http://developer.pidgin.im\n",
					                   logs_dir, buf, strerror(errno));
					g_free(name);
					g_free(logs_dir);
					g_dir_close(dir);
					g_free(status_file);
					g_free(old_user_dir);
					return FALSE;
				}

				g_free(logs_dir);
				continue;
			}

			/* Ignore all other symlinks. */

18148:f160b6e84d0c

		if (g_file_test(name, G_FILE_TEST_IS_SYMLINK))
		{
			/* We're only going to duplicate a logs symlink. */
			if (!strcmp(entry, "logs"))
			{
				char *link;
#if GLIB_CHECK_VERSION(2,4,0)
				GError *err = NULL;

				if ((link = g_file_read_link(name, &err)) == NULL)
				{
					char *name_utf8 = g_filename_to_utf8(name, -1, NULL, NULL, NULL);
					purple_debug_error("core", "Error reading symlink %s: %s. Please report this at http://developer.pidgin.im\n",
					                   name_utf8 ? name_utf8 : name, err->message);
					g_free(name_utf8);
					g_error_free(err);
					g_free(name);
					g_dir_close(dir);
					g_free(status_file);
					g_free(old_user_dir);
					return FALSE;
				}
#else
				char buf[MAXPATHLEN];
				size_t linklen;

				if ((linklen = readlink(name, buf, sizeof(buf) - 1) == -1))
				{
					char *name_utf8 = g_filename_to_utf8(name);
					purple_debug_error("core", "Error reading symlink %s: %s. Please report this at http://developer.pidgin.im\n",
					                   name_utf8, strerror(errno));
					g_free(name_utf8);
					g_free(name);
					g_dir_close(dir);
					g_free(status_file);
					g_free(old_user_dir);
					return FALSE;
				}
				buf[linklen] = '\0';

				/* This way we don't have to GLIB_VERSION_CHECK every g_free(link) below. */
				link = g_strdup(buf);
#endif

				logs_dir = g_build_filename(user_dir, "logs", NULL);

				if (!strcmp(link, "../.purple/logs") || !strcmp(link, logs_dir))
				{
					/* If the symlink points to the new directory, we're
					 * likely just trying again after a failed migration,
					 * so there's no need to fail here. */
					g_free(link);
					g_free(logs_dir);
					continue;
				}

				/* In case we are trying again after a failed migration, we need

				 * will fail, and so will the symlink below, which is good
				 * because the user should sort things out. */
				g_unlink(logs_dir);

				/* Relative links will most likely still be
				 * valid from ~/.purple, though it's not
				 * guaranteed.  Oh well. */
				if (symlink(link, logs_dir))
				{
					purple_debug_error("core", "Error symlinking %s to %s: %s. Please report this at http://developer.pidgin.im\n",
					                   logs_dir, link, strerror(errno));
					g_free(link);
					g_free(name);
					g_free(logs_dir);
					g_dir_close(dir);
					g_free(status_file);
					g_free(old_user_dir);
					return FALSE;
				}

				g_free(link);
				g_free(logs_dir);
				continue;
			}

			/* Ignore all other symlinks. */