diff libpurple/protocols/qq/group_opt.c @ 24858:09521734fe40

Fix a potential leak "KuSh" discovered using "cppcheck". Fixes #7861.
author Daniel Atallah <daniel.atallah@gmail.com>
date Mon, 22 Dec 2008 16:17:28 +0000
parents 8f757b2139d2
children 351d07aefb09
line wrap: on
line diff
--- a/libpurple/protocols/qq/group_opt.c	Mon Dec 22 16:15:40 2008 +0000
+++ b/libpurple/protocols/qq/group_opt.c	Mon Dec 22 16:17:28 2008 +0000
@@ -416,11 +416,6 @@
 
 	bytes += qq_get_vstr(&reason, QQ_CHARSET_DEFAULT, data + bytes);
 
-	add_req = g_new0(qq_room_req, 1);
-	add_req->gc = gc;
-	add_req->id = id;
-	add_req->member = member_id;
-
 	purple_debug_info("QQ", "%u requested to join room, ext id %u\n", member_id, ext_id);
 
 	rmd = qq_room_data_find(gc, id);
@@ -442,6 +437,11 @@
 	who = uid_to_purple_name(member_id);
 	msg = g_strdup_printf(_("%u request to join Qun %u"), member_id, ext_id);
 
+	add_req = g_new0(qq_room_req, 1);
+	add_req->gc = gc;
+	add_req->id = id;
+	add_req->member = member_id;
+
 	purple_request_action(gc, _("QQ Qun Operation"),
 			msg, reason,
 			PURPLE_DEFAULT_ACTION_NONE,