diff libgaim/protocols/qq/send_file.c @ 14632:108152f29f37

[gaim-migrate @ 17378] There's no reason to generate our session_md5 more than once. This probably doesn't fix the bug from Adium crash 215722, but if it happens again, it'll be a bit easier to track down. Also, I was wrong about the login scheme. Nothing significant is different, so remove the comment. committer: Tailor Script <[e-mail]>

--- a/libgaim/protocols/qq/send_file.c	Tue Sep 26 23:20:39 2006 +0000
+++ b/libgaim/protocols/qq/send_file.c	Wed Sep 27 00:31:39 2006 +0000
@@ -281,13 +281,11 @@
 {
 	gint bytes;
 	time_t now;
-	guint8 *md5;
 	guint16 seq;
 	ft_info *info;
 
 	bytes = 0;
 	now = time(NULL);
-	md5 = _gen_session_md5(qd->uid, qd->session_key);
 	if (!seq_ack) seq = qd->send_seq;
 	else {
 		info = (ft_info *) qd->xfer->data;
@@ -305,7 +303,7 @@
 	/* 014-017: sender uid */
 	bytes += create_packet_dw (raw_data, cursor, to_uid);
 	/* 018-033: md5 of (uid+session_key) */
-	bytes += create_packet_data (raw_data, cursor, md5, 16);
+	bytes += create_packet_data (raw_data, cursor, qd->session_md5, 16);
 	/* 034-035: message type */
 	bytes += create_packet_w (raw_data, cursor, message_type);
 	/* 036-037: sequence number */
@@ -332,7 +330,6 @@
 	/* 063: transfer_type,  0x65: FILE 0x6b: FACE */
 	bytes += create_packet_b (raw_data, cursor, QQ_FILE_TRANSFER_FILE); /* FIXME */
 
-	g_free (md5);
 	return bytes;
 }