diff plugins/gestures/stroke.c @ 9843:19fd43d52d18

[gaim-migrate @ 10721] " I didn't notice this bug had been closed until I went looking for it again. :) I have been able to crash Gaim 0.82cvs using the method described in the bug. It looks like there was a patch to the gestures plugin to catch a case where it catches the release of a non-gestures button and the gesture is active. It seems as though there is a way to confuse GDK (or the gestures plugin) into missing the button release event for the gestures button by sending it a bunch of events at the same time (chord-clicking all 3 buttons of the mouse at once). This patch traps when other buttons are clicked after a gesture is active and cancels the gesture. I don't know if it's the Right Fix(tm), but it does keep it from crashing on my system. I also trapped a place or two where it would actually segfault in Gaim; the button trap is more of a fix to keep the gesture from "sticking". If the gesture sticks and we trap the null data pointers, Gaim still crashes with a badDrawable X error. The error was 'BadDrawable (invalid Pixmap or Window parameter)'. (Details: serial 5520 error_code 9 request_code 66 minor_code 0) " --Dave (kat) West committer: Tailor Script <[e-mail]>

--- a/plugins/gestures/stroke.c	Mon Aug 23 23:10:21 2004 +0000
+++ b/plugins/gestures/stroke.c	Mon Aug 23 23:56:23 2004 +0000
@@ -190,6 +190,8 @@
   gint delx, dely;
   float ix, iy;
 
+  g_return_if_fail( metrics != NULL );
+
 #if 0
   printf ("%d:%d ", x, y); fflush (stdout);
 #endif