Mercurial > pidgin
diff libpurple/protocols/oscar/odc.c @ 16391:24bbd7e46bfe
Change the imgstore and by extension, then the buddy icon code to take over
the references to icon data instead of calling g_memdup(). This eliminates
g_memdup()ing and g_free()ing in ~50% of the callers. For the rest, it's no
worse (they now do a g_memdup() instead of the core) and they may be able to
be modified in the future to avoid that.
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Wed, 25 Apr 2007 22:23:29 +0000 |
| parents | 391a79778f89 |
| children | 648551e3243a |
line wrap: on
line diff
--- a/libpurple/protocols/oscar/odc.c Wed Apr 25 21:48:56 2007 +0000 +++ b/libpurple/protocols/oscar/odc.c Wed Apr 25 22:23:29 2007 +0000 @@ -353,7 +353,7 @@ if ((embedded_data != NULL) && (embedded_data->size == size)) { - imgid = purple_imgstore_add_with_id(embedded_data->data, size, src); + imgid = purple_imgstore_add_with_id(g_memdup(embedded_data->data, size), size, src); /* Record the image number */ images = g_slist_append(images, GINT_TO_POINTER(imgid));