Mercurial > pidgin
diff libpurple/util.c @ 31905:323876c34a96
Don't use strlen() when all you're trying to do is check if the string
is empty
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Mon, 22 Aug 2011 02:07:41 +0000 |
parents | 7df08e88d9bb |
children | 99ca503ea087 |
line wrap: on
line diff
--- a/libpurple/util.c Mon Aug 22 01:53:37 2011 +0000 +++ b/libpurple/util.c Mon Aug 22 02:07:41 2011 +0000 @@ -147,7 +147,7 @@ len = strlen(str); - g_return_val_if_fail(strlen(str) > 0, 0); + g_return_val_if_fail(*str, 0); g_return_val_if_fail(len % 2 == 0, 0); data = g_malloc(len / 2); @@ -2267,7 +2267,7 @@ url_buf = g_string_free(gurl_buf, FALSE); /* strip off trailing periods */ - if (strlen(url_buf) > 0) { + if (*url_buf) { for (d = url_buf + strlen(url_buf) - 1; *d == '.'; d--, t--) *d = '\0'; }