diff libpurple/protocols/msn/slpmsg_part.c @ 31031:61db10475bed

As Mark did before, we probably don't need a return value from these unref functions. Also, make the ref counts unsigned.
author Elliott Sales de Andrade <qulogic@pidgin.im>
date Wed, 15 Dec 2010 04:17:59 +0000
parents 72e6fa6caecc
children 05e05d96ba75
line wrap: on
line diff
--- a/libpurple/protocols/msn/slpmsg_part.c	Wed Dec 15 00:00:12 2010 +0000
+++ b/libpurple/protocols/msn/slpmsg_part.c	Wed Dec 15 04:17:59 2010 +0000
@@ -102,31 +102,27 @@
 MsnSlpMessagePart *msn_slpmsgpart_ref(MsnSlpMessagePart *part)
 {
 	g_return_val_if_fail(part != NULL, NULL);
-	part->ref_count ++;
+	part->ref_count++;
 
 	if (purple_debug_is_verbose())
-		purple_debug_info("msn", "part ref (%p)[%d]\n", part, part->ref_count);
+		purple_debug_info("msn", "part ref (%p)[%u]\n", part, part->ref_count);
 
 	return part;
 }
 
-MsnSlpMessagePart *msn_slpmsgpart_unref(MsnSlpMessagePart *part)
+void msn_slpmsgpart_unref(MsnSlpMessagePart *part)
 {
-	g_return_val_if_fail(part != NULL, NULL);
-	g_return_val_if_fail(part->ref_count > 0, NULL);
+	g_return_if_fail(part != NULL);
+	g_return_if_fail(part->ref_count > 0);
 
 	part->ref_count--;
 
 	if (purple_debug_is_verbose())
-		purple_debug_info("msn", "part unref (%p)[%d]\n", part, part->ref_count);
+		purple_debug_info("msn", "part unref (%p)[%u]\n", part, part->ref_count);
 
 	if (part->ref_count == 0) {
 		msn_slpmsgpart_destroy(part);
-
-		 return NULL;
 	}
-
-	return part;
 }
 
 void msn_slpmsgpart_set_bin_data(MsnSlpMessagePart *part, const void *data, size_t len)
@@ -234,3 +230,4 @@
 
 	slpmsg->parts = g_list_remove(slpmsg->parts, part);
 }
+