diff libpurple/protocols/irc/msgs.c @ 32784:665388a0f573

Remove periodic WHO on IRC. I believe I have left enough functionality here that a misguided libpurple client can continue to trigger WHO from its own UI. References #11089, #14602 Fixes #14955
author Ethan Blanton <elb@pidgin.im>
date Thu, 03 May 2012 00:09:14 +0000
parents d2eb28c12d44
children f911cdafdcd8
line wrap: on
line diff
--- a/libpurple/protocols/irc/msgs.c	Fri Apr 20 08:03:08 2012 +0000
+++ b/libpurple/protocols/irc/msgs.c	Thu May 03 00:09:14 2012 +0000
@@ -3,7 +3,7 @@
  *
  * purple
  *
- * Copyright (C) 2003, Ethan Blanton <eblanton@cs.purdue.edu>
+ * Copyright (C) 2003, 2012 Ethan Blanton <elb@pidgin.im>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -110,8 +110,6 @@
 	irc_blist_timeout(irc);
 	if (!irc->timer)
 		irc->timer = purple_timeout_add_seconds(45, (GSourceFunc)irc_blist_timeout, (gpointer)irc);
-    if (!irc->who_channel_timer)
-        irc->who_channel_timer = purple_timeout_add_seconds(300, (GSourceFunc)irc_who_channel_timeout, (gpointer)irc);
 }
 
 void irc_msg_default(struct irc_conn *irc, const char *name, const char *from, char **args)
@@ -463,6 +461,10 @@
 		
 		flags = cb->flags;
 
+		/* FIXME: I'm not sure this is really a good idea, now
+		 * that we no longer do periodic WHO.  It seems to me
+		 * like it's more likely to be confusing than not.
+		 * Comments? */
 		if (args[6][0] == 'G' && !(flags & PURPLE_CBFLAGS_AWAY)) {
 			purple_conv_chat_user_set_flags(chat, cb->name, flags | PURPLE_CBFLAGS_AWAY);
 		} else if(args[6][0] == 'H' && (flags & PURPLE_CBFLAGS_AWAY)) {