Mercurial > pidgin
diff ChangeLog @ 32376:82024b6ea465
Fix remotely-triggerable crashes by validating strings in a few
messages related to buddy list management. Fixes #14682
I changed the four functions that parse incoming authorization-related
SNACs. The changes are:
- Make sure we have a buddy name and it is valid UTF-8. If not, we
drop the SNAC and log a debug message (we can't do much with an empty,
invalid or incorrect buddy name). This wasn't a part of the bug
report and I doubt it's actually a problem, but it seems like a good
idea regardless.
- If the incoming message is not valid UTF-8 then use
purple_utf8_salvage() to replace invalid bytes with question marks. I
believe this fixes the bug in question.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Tue, 06 Dec 2011 06:40:23 +0000 |
parents | d6cc1ff0d9b7 |
children | 9c9df712b191 |
line wrap: on
line diff
--- a/ChangeLog Wed Nov 30 01:04:16 2011 +0000 +++ b/ChangeLog Tue Dec 06 06:40:23 2011 +0000 @@ -4,6 +4,10 @@ Finch: * Fix compilation on OpenBSD. + AIM and ICQ: + * Fix remotely-triggerable crashes by validating strings in a few + messages related to buddy list management. (#14682) + Bonjour: * IPv6 fixes (Linus Lüssing)