Mercurial > pidgin
diff ChangeLog @ 27039:9a79f8a99259
Set charset=utf-8 when cyrus sasl doesn't include it.
Both deryni and my reading of the digest md5 cyrus plugin is that the response
will never actually include the charset (digestmd5.c:make_client_response,
look for IsUTF8). I future-proofed this code by checking for it anyway.
To be polite for older servers, we might want to only send this if the server
sent charset=utf-8 in the challenge (and encode everything to ISO-8859-1).
However, the RFC doesn't say always sending it is wrong (and that's what
the in-tree implementation does).
| author | Paul Aurich <paul@darkrain42.org> |
|---|---|
| date | Fri, 05 Jun 2009 07:02:16 +0000 |
| parents | e6031586fd1b |
| children | 1fd829110a6d |
line wrap: on
line diff
--- a/ChangeLog Fri Jun 05 05:44:44 2009 +0000 +++ b/ChangeLog Fri Jun 05 07:02:16 2009 +0000 @@ -52,6 +52,9 @@ chat to avoid getting too many fetch requests). * Fix an issue with Jabber (pre-XMPP) servers and the user's preference to require SSL not being respected. + * Fix an issue where Cyrus SASL DIGEST MD5 authentication might fail if + the username, password, or realm (the JID domain) contain characters + not in ISO-8859-1. Yahoo: * P2P file transfers. (Sulabh Mahajan)