diff src/dialogs.c @ 7751:d691cb95ee67

[gaim-migrate @ 8396] Changes for the conversation "Find" dialog: -Makes the window manager "X" work correctly when closing the dialog -Added an "s" mnemonic for the search box -Hitting enter now performs the default action (Find) -The Find button grays and un-grays (aka sensitizes and desensitizes) itself based on the presence or absence of text in the search box. For this I moved a function from dialogs.c to util.[c|h]: gaim_gtk_set_sensitive_if_input() -HIGification suggestions from Steven Garrity: 1. Give the window a title ("Find") as is recommended by the HIG (http://developer.gnome.org/projects/gup/hig/1.0/windows.html#window-properties). 2. Drop the phrase "Enter a search phrase" altogether. Since the text box is already labeled (and if the window was labeled too), this phrase is redundant. Removing it simplifies the visual appearance of the window, and is one less thing to translate. 3.Change text box label from "Search term:" to "Search for:". This isn't a big deal, but the Search window in GEdit uses "Search for:" (I couldn't find much consistency anywhere else). 4.Move "Close" and "Find" buttons to be 12 pixels from the bottom and right edges of the window, as recommended by the HIG (http://developer.gnome.org/projects/gup/hig/1.0/layout.html#window-layout-spacing). Also thanks to Nathan Fredrickson for writing a patch for Steven's suggestions. committer: Tailor Script <[e-mail]>

--- a/src/dialogs.c	Thu Dec 04 20:43:27 2003 +0000
+++ b/src/dialogs.c	Thu Dec 04 22:09:58 2003 +0000
@@ -629,12 +629,6 @@
 	info->gc = gaim_account_get_connection(account);
 }
 
-static void dialog_set_ok_sensitive(GtkWidget *entry, GtkWidget *dlg) {
-	const char *txt = gtk_entry_get_text(GTK_ENTRY(entry));
-	gtk_dialog_set_response_sensitive(GTK_DIALOG(dlg), GTK_RESPONSE_OK,
-			(*txt != '\0'));
-}
-
 void show_im_dialog()
 {
 	GtkWidget *hbox, *vbox;
@@ -692,7 +686,7 @@
 		gtk_entry_set_activates_default (GTK_ENTRY(info->entry), TRUE);
 		gtk_label_set_mnemonic_widget(GTK_LABEL(label), GTK_WIDGET(info->entry));
 		g_signal_connect(G_OBJECT(info->entry), "changed",
-				G_CALLBACK(dialog_set_ok_sensitive), imdialog);
+				G_CALLBACK(gaim_gtk_set_sensitive_if_input), imdialog);
 
 		if (gaim_connections_get_all()->next) {
 
@@ -770,7 +764,7 @@
 	gtk_label_set_mnemonic_widget(GTK_LABEL(label), GTK_WIDGET(info->entry));
 
 	g_signal_connect(G_OBJECT(info->entry), "changed",
-			G_CALLBACK(dialog_set_ok_sensitive), window);
+			G_CALLBACK(gaim_gtk_set_sensitive_if_input), window);
 
 	if (gaim_connections_get_all()->next) {