Mercurial > pidgin
diff ChangeLog @ 29659:df9de37e0274
gnutls/nss: Don't call the handshake functions synchronously. Fixes #11525
If the handshake callbacks are called sychronously and they fail
(e.g. passing GnuTLS a bad priority string or doing voodoo with NSS, see
#11524 for details), the error_cb is called and the gsc destroyed, but this
happens /before/ the assignment to, e.g., js->gsc happens (see
jabber.c:tls_init). Thus, js->gsc is assigned a (now invalid) pointer
and jabber_close tries to free it (again).
author | Paul Aurich <paul@darkrain42.org> |
---|---|
date | Thu, 01 Apr 2010 05:26:44 +0000 |
parents | 89de871ecffc |
children | fc4bacb35cbc |
line wrap: on
line diff
--- a/ChangeLog Thu Apr 01 04:58:17 2010 +0000 +++ b/ChangeLog Thu Apr 01 05:26:44 2010 +0000 @@ -6,6 +6,9 @@ * Changed GLib minimum version requirement to 2.12.0. * Using the --disable-nls argument to configre now works properly. You will no longer be forced to have intltool to configure and build. + * Fix two related crashes in the GnuTLS and NSS plugins when they + suffer internal errors immediately upon attempting to establish + an SSL connection. * Added support for PURPLE_GNUTLS_PRIORITIES environment variable. This can be used to specify GnuTLS priorities on a per-host basis. The format is "host=priority;host2=priority;...". The default